Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option's width is wrong in version 2.13.1 under the react version 16.0.0-rc.3 #7609

Closed
dingchaoyan1983 opened this issue Sep 15, 2017 · 16 comments
Assignees
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@dingchaoyan1983
Copy link

Version

2.13.1

Environment

react version: 16.0.0-rc.3

Reproduction link

https://codepen.io/dingchaoyan1983/pen/bodwrQ

Steps to reproduce

render a select

What is expected?

5a52f4ab-1a4b-44eb-bda8-4b00564f0f07

The option width of Select in antd's version 2.13.1 is wrong in react version 16.0.0-rc.3

What is actually happening?

5a52f4ab-1a4b-44eb-bda8-4b00564f0f07

The option width of Select in antd's version 2.13.1 is wrong in react version 16.0.0-rc.3

@benjycui benjycui added the 🐛 Bug Ant Design Team had proved that this is a bug. label Sep 15, 2017
@dingchaoyan1983
Copy link
Author

dingchaoyan1983 commented Sep 16, 2017

under the further investigate, this issue is related a react16 breaking changes facebook/react#10310

@dingchaoyan1983
Copy link
Author

more context please check facebook/react#10294 (comment)

@gaearon
Copy link

gaearon commented Sep 16, 2017

It is not a bug but an intentional breaking change. Please change your usage of renderSubtreeIntoContainer to ReactDOM.createPortal which is available in 16. You can check for whether it exists and branch in the code.

@dingchaoyan1983
Copy link
Author

dingchaoyan1983 commented Sep 18, 2017

@benjycui yes, I have already debuged to this function also, but I don't know how to correct it, because I have no more context for this, i don't read the whole code, almost it use to create a dom out of react root.

@benjycui benjycui assigned benjycui and yesmeck and unassigned benjycui Sep 19, 2017
@kooinam
Copy link

kooinam commented Sep 29, 2017

any quick patch for this?

@kooinam
Copy link

kooinam commented Oct 13, 2017

any update or should we revert back to react 15?

@afc163
Copy link
Member

afc163 commented Oct 16, 2017

@yesmeck
Copy link
Member

yesmeck commented Oct 16, 2017

I'm looking into it.

@dvdhsu
Copy link

dvdhsu commented Oct 17, 2017

@yesmeck can you bump the version? That way when ant-design is reinstalled, we'll get the fix automatically. Thanks!

@yesmeck
Copy link
Member

yesmeck commented Oct 17, 2017

rc-select@6.9.4

@yizhoucao
Copy link

@yesmeck tree select has the same issue. Could you please fix that as well? Thanks.

http://beta.ant.design/components/tree-select/

@ElliotReeve
Copy link

I updated to 2.13.7 but I still get this issue, do I need to do something else? Thanks

@yesmeck
Copy link
Member

yesmeck commented Oct 23, 2017

@ElliotReeve Ensure npm list rc-select is 6.9.5, otherwise, reinstall node_modules.

@yesmeck
Copy link
Member

yesmeck commented Oct 23, 2017

@yizhoucao Fixed in rc-tree-select@1.10.11

@pueding
Copy link

pueding commented Oct 23, 2017

@yesmeck thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Development

No branches or pull requests

10 participants