Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress component can not display well in table #8239

Closed
kennylbj opened this issue Nov 20, 2017 · 5 comments
Closed

Progress component can not display well in table #8239

kennylbj opened this issue Nov 20, 2017 · 5 comments

Comments

@kennylbj
Copy link

kennylbj commented Nov 20, 2017

Version

2.13.10

Environment

OS: macOS High Sierra
browser: Chrome Version 61.0.3163.100 (Official Build) (64-bit)

Reproduction link

https://codepen.io/kennylbj/pen/KyveQq?editors=0011

Steps to reproduce

Render Progress component in table

What is expected?

Display Progress component in one line.

What is actually happening?

The percentage text of Progress component is broke up into two lines if the percentage value is larger than 9.
image

@yesmeck
Copy link
Member

yesmeck commented Nov 20, 2017

For now, you can set a custom class name on the Progress and set word-break to normal.

<Progress className="my-progress" percent={progress} status='active' />
.my-progress {
  word-break: normal;  
}

@kennylbj
Copy link
Author

@yesmeck Problem solved, thx.
Waiting for official fix anyway.

@yesmeck
Copy link
Member

yesmeck commented Nov 20, 2017

I'm afraid this issue won't be fixed, because table is agnostic of what you render to the cell. Maybe we can add a wordBreak option to the column, I'm not sure.

@kennylbj
Copy link
Author

You are right. IMO, however, adding Progress with additional styles in order to work fine with table is kind of odd.

@yesmeck
Copy link
Member

yesmeck commented Nov 20, 2017

Added word-break: normal; as progress's default style.

@yesmeck yesmeck closed this as completed Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants