Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 10445 #10457

Merged
merged 6 commits into from May 10, 2018
Merged

fix 10445 #10457

merged 6 commits into from May 10, 2018

Conversation

jljsj33
Copy link
Member

@jljsj33 jljsj33 commented May 10, 2018

  1. 修复 float 布局错位
    image

  2. 动画时间用 0.3。 跟输入框时间同步。。。

  3. 强制修改 state.helpShow 来决定显示的状态,,避逸流氓输入 bug Form表单项校验位置高度出现抖动 #10445

@jljsj33 jljsj33 requested a review from afc163 May 10, 2018 07:48
@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #10457 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10457      +/-   ##
==========================================
+ Coverage   86.47%   86.48%   +<.01%     
==========================================
  Files         196      196              
  Lines        4792     4795       +3     
  Branches     1338     1339       +1     
==========================================
+ Hits         4144     4147       +3     
  Misses        645      645              
  Partials        3        3
Impacted Files Coverage Δ
components/form/FormItem.tsx 97.87% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0d421...57febfe. Read the comment docs.

@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit 785cbd3

https://deploy-preview-10457--ant-design.netlify.com

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 10, 2018

Deploy preview for ant-design ready!

Built with commit 57febfe

https://deploy-preview-10457--ant-design.netlify.com

@jljsj33
Copy link
Member Author

jljsj33 commented May 10, 2018

想明白了,,吗的。。。false -> true -> false -> true 时,,元素从第一个 true 时就一直存在的。。。animate 里是等 end 后切状态。。。所以在第二个 false 时值还是 true 的。。 。 在 children 里判断 true 是为了在第二个 false 这时避免掉换样式。。。你那样的写法第二个 false 在开始时给值了。。。第二个 false 应该在动画结束给值

@mzohaibqc
Copy link
Contributor

@jljsj33
Copy link
Member Author

jljsj33 commented May 10, 2018

再理一下。。。
false -> true -> false -> true

false true false true
24 5 24 5 抖动问题判断第二个 false ,元素并未删除
24 5 5 5 正确

这时的不显示其实还是处理显示的状态。。。

显示状态不需要等动画结束去改状态,,一开始就需要更换

@jljsj33
Copy link
Member Author

jljsj33 commented May 10, 2018

@mzohaibqc thx, you can also direct pr

@jljsj33
Copy link
Member Author

jljsj33 commented May 10, 2018

@mzohaibqc fix

@jljsj33
Copy link
Member Author

jljsj33 commented May 10, 2018

@afc163 这样写 state.helpShow 其实一点用都没了。。。你再重构吧,,,反正问题在上面了,,,

@afc163 afc163 merged commit 9e01b24 into master May 10, 2018
@afc163 afc163 deleted the form-explain branch May 10, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants