Bugfix/table onchange event fired everytime when close filterdropdown #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen close filterDropdown
1 task
|
Deploy preview for ant-design ready! Built with commit d549b9d |
Codecov Report
@@ Coverage Diff @@
## master #11166 +/- ##
==========================================
+ Coverage 91.64% 91.65% +<.01%
==========================================
Files 194 194
Lines 4788 4791 +3
Branches 1336 1337 +1
==========================================
+ Hits 4388 4391 +3
Misses 396 396
Partials 4 4
Continue to review full report at Codecov.
|
yesmeck
reviewed
Jul 12, 2018
| this.props.confirmFilter(this.props.column, this.state.selectedKeys); | ||
| const { selectedKeys } = this.state; | ||
|
|
||
| if (this.hasSelectedKeys() && !shallowequal(selectedKeys, this.props.selectedKeys)) { |
There was a problem hiding this comment.
Don't need this.hasSelectedKeys(), if state.selectedKeys and props.selectedKeys are both empty, they are shallow equal, otherwise, if one is empty and the other one is not, they are absolutely not shallow equal.
|
Merged in 968371b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix this bug #11164