Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onMouseEnter and onMouseLeave to SelectProps #11314

Merged
merged 1 commit into from Jul 17, 2018
Merged

Add onMouseEnter and onMouseLeave to SelectProps #11314

merged 1 commit into from Jul 17, 2018

Conversation

DanielHZhang
Copy link
Contributor

@DanielHZhang DanielHZhang commented Jul 17, 2018

Fixes #11295

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit 7a8cc3b

https://deploy-preview-11314--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #11314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11314   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         199      199           
  Lines        5005     5005           
  Branches     1402     1402           
=======================================
  Hits         4593     4593           
  Misses        407      407           
  Partials        5        5
Impacted Files Coverage Δ
components/select/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c696757...7a8cc3b. Read the comment docs.

@afc163 afc163 merged commit 308cb04 into ant-design:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: <Select/> - onMouseEnter and onMouseLeave does not exist when passed as props
3 participants