Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit on Font Display CSS attribute #11518

Merged
merged 1 commit into from Jul 30, 2018

Conversation

ooiyeewei
Copy link
Contributor

@ooiyeewei ooiyeewei commented Jul 30, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit 15d902e

https://deploy-preview-11518--ant-design.netlify.com

@ooiyeewei ooiyeewei changed the title First commit First commit on Font Display CSS attribute Jul 30, 2018
@afc163 afc163 merged commit c849a73 into ant-design:master Jul 30, 2018
@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #11518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11518   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         199      199           
  Lines        5030     5030           
  Branches     1409     1372   -37     
=======================================
  Hits         4620     4620           
  Misses        406      406           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ca64b...15d902e. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 2, 2018

close #11142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants