Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew typescript typings #11649

Merged
merged 1 commit into from Aug 7, 2018
Merged

Renew typescript typings #11649

merged 1 commit into from Aug 7, 2018

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 7, 2018

更靠谱的 typings 依赖。

@afc163 afc163 force-pushed the fix-and-improve-typescript branch from ad92fb7 to bc9cef6 Compare August 7, 2018 13:29
@afc163
Copy link
Member Author

afc163 commented Aug 7, 2018

lodash/xxx 有点不好搞。

@afc163 afc163 requested a review from yesmeck August 7, 2018 13:29
@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design failed.

Built with commit fa55aa2a9647d3e041bb31130e29eb8fd520b6e5

https://app.netlify.com/sites/ant-design/deploys/5b699ae267610c14a3d158f9

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 7, 2018

Deploy preview for ant-design ready!

Built with commit d45a98e

https://deploy-preview-11649--ant-design.netlify.com

@afc163 afc163 force-pushed the fix-and-improve-typescript branch from bc9cef6 to 50f1403 Compare August 7, 2018 14:31
@afc163 afc163 force-pushed the fix-and-improve-typescript branch from 50f1403 to d45a98e Compare August 7, 2018 15:00
@afc163
Copy link
Member Author

afc163 commented Aug 7, 2018

放弃,classnames warning shallowequal 都不好搞,ts 过了 jest 就失败。

@IssueHuntBot IssueHuntBot mentioned this pull request Aug 7, 2018
1 task
@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #11649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11649   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         199      199           
  Lines        5098     5098           
  Branches     1433     1433           
=======================================
  Hits         4688     4688           
- Misses        404      406    +2     
+ Partials        6        4    -2
Impacted Files Coverage Δ
components/date-picker/locale/th_TH.tsx 100% <ø> (ø) ⬆️
components/time-picker/index.tsx 74.5% <0%> (ø) ⬆️
components/transfer/index.tsx 87.41% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064bfaf...d45a98e. Read the comment docs.

@afc163 afc163 merged commit 287d088 into master Aug 7, 2018
@afc163 afc163 deleted the fix-and-improve-typescript branch August 7, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants