Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor component with affix=true doesn't work inside inner scrollable… #11688

merged 1 commit into from Aug 10, 2018

Anchor component with affix=true doesn't work inside inner scrollable… #11688

merged 1 commit into from Aug 10, 2018


Copy link

… container #11687

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Copy link

Deploy preview for ant-design ready!

Built with commit 6a14248

Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #11688 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11688      +/-   ##
- Coverage   92.03%   91.99%   -0.04%     
  Files         200      200              
  Lines        5109     5109              
  Branches     1433     1433              
- Hits         4702     4700       -2     
- Misses        403      405       +2     
  Partials        4        4
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 90.9% <100%> (ø) ⬆️
components/affix/index.tsx 87.5% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f78cc9...6a14248. Read the comment docs.

@afc163 afc163 merged commit a14e476 into ant-design:master Aug 10, 2018
@vitaliymaz vitaliymaz deleted the fix-anchor-affix-inside-container branch August 10, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants