Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Grid with new context API #12320

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Refactor Grid with new context API #12320

merged 2 commits into from
Sep 21, 2018

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Sep 19, 2018

#9870

You can use wrapped Col in the Row with gutter now:

const MyCol = () => <Col span={12}>1</Col>;

<Row>
  <MyCol />
  <Col span={12}>2</Col>
</Row>

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 19, 2018

Deploy preview for ant-design ready!

Built with commit e118703

https://deploy-preview-12320--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Sep 19, 2018

👍

@afc163
Copy link
Member

afc163 commented Sep 19, 2018

feature 分支吧。

@yesmeck yesmeck changed the base branch from master to feature September 19, 2018 10:03
@afc163
Copy link
Member

afc163 commented Sep 21, 2018

ci broken

@yesmeck
Copy link
Member Author

yesmeck commented Sep 21, 2018

顺便修了 List 的一个 bug

@yesmeck yesmeck force-pushed the refactor-col branch 3 times, most recently from 840c7a8 to b76f8a3 Compare September 21, 2018 09:33
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #12320 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #12320   +/-   ##
========================================
  Coverage    92.31%   92.31%           
========================================
  Files          210      211    +1     
  Lines         5530     5530           
  Branches      1589     1577   -12     
========================================
  Hits          5105     5105           
+ Misses         421      419    -2     
- Partials         4        6    +2
Impacted Files Coverage Δ
components/grid/RowContext.tsx 100% <100%> (ø)
components/grid/col.tsx 100% <100%> (ø) ⬆️
components/grid/row.tsx 66.66% <100%> (-3.93%) ⬇️
components/transfer/index.tsx 87.91% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a77ef...e118703. Read the comment docs.

@afc163 afc163 merged commit ca7d265 into feature Sep 21, 2018
@afc163 afc163 deleted the refactor-col branch September 21, 2018 11:30
@warmhug
Copy link
Contributor

warmhug commented Oct 23, 2018

这里应该产生了新 bug, gutter 在外层组件中会传入?

@yesmeck
Copy link
Member Author

yesmeck commented Oct 23, 2018

什么意思

@warmhug
Copy link
Contributor

warmhug commented Oct 23, 2018

@yesmeck 看内网 bigfish issue 的详细描述

@yesmeck yesmeck restored the refactor-col branch December 25, 2018 16:05
@yesmeck yesmeck deleted the refactor-col branch December 25, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants