New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Grid with new context API #12320

Merged
merged 2 commits into from Sep 21, 2018

Conversation

Projects
None yet
4 participants
@yesmeck
Member

yesmeck commented Sep 19, 2018

#9870

You can use wrapped Col in the Row with gutter now:

const MyCol = () => <Col span={12}>1</Col>;

<Row>
  <MyCol />
  <Col span={12}>2</Col>
</Row>
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 19, 2018

Deploy preview for ant-design ready!

Built with commit e118703

https://deploy-preview-12320--ant-design.netlify.com

@afc163

This comment has been minimized.

Member

afc163 commented Sep 19, 2018

👍

@afc163

This comment has been minimized.

Member

afc163 commented Sep 19, 2018

feature 分支吧。

@yesmeck yesmeck force-pushed the refactor-col branch from 884a88b to 87cc2b3 Sep 19, 2018

@yesmeck yesmeck changed the base branch from master to feature Sep 19, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Sep 21, 2018

ci broken

@yesmeck

This comment has been minimized.

Member

yesmeck commented Sep 21, 2018

顺便修了 List 的一个 bug

@yesmeck yesmeck force-pushed the refactor-col branch 3 times, most recently from 840c7a8 to b76f8a3 Sep 21, 2018

@yesmeck yesmeck force-pushed the refactor-col branch from b76f8a3 to e118703 Sep 21, 2018

@codecov

This comment has been minimized.

codecov bot commented Sep 21, 2018

Codecov Report

Merging #12320 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #12320   +/-   ##
========================================
  Coverage    92.31%   92.31%           
========================================
  Files          210      211    +1     
  Lines         5530     5530           
  Branches      1589     1577   -12     
========================================
  Hits          5105     5105           
+ Misses         421      419    -2     
- Partials         4        6    +2
Impacted Files Coverage Δ
components/grid/RowContext.tsx 100% <100%> (ø)
components/grid/col.tsx 100% <100%> (ø) ⬆️
components/grid/row.tsx 66.66% <100%> (-3.93%) ⬇️
components/transfer/index.tsx 87.91% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a77ef...e118703. Read the comment docs.

@afc163 afc163 merged commit ca7d265 into feature Sep 21, 2018

21 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.31%)
Details
codecov/project 92.31% (+0%) compared to d5a77ef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the refactor-col branch Sep 21, 2018

@warmhug

This comment has been minimized.

Contributor

warmhug commented Oct 23, 2018

这里应该产生了新 bug, gutter 在外层组件中会传入?

@yesmeck

This comment has been minimized.

Member

yesmeck commented Oct 23, 2018

什么意思

@warmhug

This comment has been minimized.

Contributor

warmhug commented Oct 23, 2018

@yesmeck 看内网 bigfish issue 的详细描述

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment