-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use less @plugin #13595
Use less @plugin #13595
Conversation
Deploy preview for ant-design ready! Built with commit 2d5d71b |
Codecov Report
@@ Coverage Diff @@
## master #13595 +/- ##
==========================================
+ Coverage 93.63% 93.68% +0.04%
==========================================
Files 314 314
Lines 6631 6631
Branches 1767 1767
==========================================
+ Hits 6209 6212 +3
+ Misses 410 407 -3
Partials 12 12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #13595 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 314 314
Lines 6631 6631
Branches 1767 1736 -31
=======================================
Hits 6212 6212
Misses 407 407
Partials 12 12
Continue to review full report at Codecov.
|
return { level: level, size: size }; | ||
} | ||
|
||
module.exports = tinycolor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是可以精简一下我们用到的功能。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果精简不了,干脆直接走 npm 依赖。
This pull request introduces 5 alerts when merging 2546a30 into 05cf557 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 6 alerts when merging c5462e4 into 05cf557 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 3 alerts when merging 2d5d71b into 05cf557 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
剩下的交给我吧 我做一个新的插件 |
master? |
还是发到 feature 吧 |
这个变更对打包产物没有影响。 @chenshuai2144 ,先把换主题功能下了? |
javascriptEnable 不用开了,可以吹一波,还是放到 feature 大版本来发。 然后文档里涉及 javascriptEnable 的也要改一波。 |
这个代码尚未提交到 feature |
试验了一下,使用
less-loader
的 preload plugins 可以正常解析,但是会导致 es/lib 调用也需要配置 preload plugin,太麻烦。还是先用空 less 文件来让它正常解析算了。compile
dist
bisheng
都过了,准备开始研究配置主题,代码可以先过一遍。ref: #13242