Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use less @plugin #13595

Merged
merged 16 commits into from
Dec 13, 2018
Merged

Use less @plugin #13595

merged 16 commits into from
Dec 13, 2018

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 12, 2018

试验了一下,使用 less-loader 的 preload plugins 可以正常解析,但是会导致 es/lib 调用也需要配置 preload plugin,太麻烦。还是先用空 less 文件来让它正常解析算了。

compile dist bisheng 都过了,准备开始研究配置主题,代码可以先过一遍。

ref: #13242

@netlify
Copy link

netlify bot commented Dec 12, 2018

Deploy preview for ant-design ready!

Built with commit 2d5d71b

https://deploy-preview-13595--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #13595 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13595      +/-   ##
==========================================
+ Coverage   93.63%   93.68%   +0.04%     
==========================================
  Files         314      314              
  Lines        6631     6631              
  Branches     1767     1767              
==========================================
+ Hits         6209     6212       +3     
+ Misses        410      407       -3     
  Partials       12       12
Impacted Files Coverage Δ
components/steps/index.tsx 100% <0%> (ø) ⬆️
components/_util/wave.tsx 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a66546...fa00794. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #13595 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13595   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         314      314           
  Lines        6631     6631           
  Branches     1767     1736   -31     
=======================================
  Hits         6212     6212           
  Misses        407      407           
  Partials       12       12
Impacted Files Coverage Δ
components/steps/index.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a66546...2d5d71b. Read the comment docs.

return { level: level, size: size };
}

module.exports = tinycolor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是可以精简一下我们用到的功能。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果精简不了,干脆直接走 npm 依赖。

@afc163
Copy link
Member

afc163 commented Dec 13, 2018

This pull request introduces 5 alerts when merging 2546a30 into 05cf557 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

Comment posted by LGTM.com

@afc163
Copy link
Member

afc163 commented Dec 13, 2018

This pull request introduces 6 alerts when merging c5462e4 into 05cf557 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

Comment posted by LGTM.com

@afc163
Copy link
Member

afc163 commented Dec 13, 2018

This pull request introduces 3 alerts when merging 2d5d71b into 05cf557 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

Comment posted by LGTM.com

@chenshuai2144
Copy link
Contributor

chenshuai2144 commented Dec 13, 2018

剩下的交给我吧

我做一个新的插件

@chenshuai2144 chenshuai2144 changed the title [WIP] Use less @plugin Use less @plugin Dec 13, 2018
@chenshuai2144 chenshuai2144 merged commit 377062b into master Dec 13, 2018
@chenshuai2144 chenshuai2144 deleted the lessPlugin branch December 13, 2018 04:23
@afc163
Copy link
Member

afc163 commented Dec 13, 2018

master?

@afc163
Copy link
Member

afc163 commented Dec 13, 2018

还是发到 feature 吧

@zombieJ
Copy link
Member Author

zombieJ commented Dec 13, 2018

这个变更对打包产物没有影响。

@chenshuai2144 ,先把换主题功能下了?

@afc163
Copy link
Member

afc163 commented Dec 13, 2018

javascriptEnable 不用开了,可以吹一波,还是放到 feature 大版本来发。

然后文档里涉及 javascriptEnable 的也要改一波。

@chenshuai2144 chenshuai2144 restored the lessPlugin branch December 13, 2018 10:08
@chenshuai2144 chenshuai2144 deleted the lessPlugin branch December 13, 2018 11:12
@afc163 afc163 restored the lessPlugin branch December 13, 2018 14:32
@afc163 afc163 deleted the lessPlugin branch December 20, 2018 09:47
@afc163
Copy link
Member

afc163 commented Dec 22, 2018

这个代码尚未提交到 feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants