Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11504 - added bodyStyle #13729

Closed
wants to merge 1 commit into from
Closed

#11504 - added bodyStyle #13729

wants to merge 1 commit into from

Conversation

rahgurung
Copy link
Contributor

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your pull request, thank you!

  • Make sure that you propose pull request to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a pull request to keep commit history clear.
  • Add some descriptions and refer relative issues for you pull request.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@rahgurung rahgurung changed the title 11504 - added bodyStyle #11504 - added bodyStyle Dec 20, 2018
@netlify
Copy link

netlify bot commented Dec 20, 2018

Deploy preview for ant-design ready!

Built with commit 7e0b81f

https://deploy-preview-13729--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13729   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         314      314           
  Lines        6646     6646           
  Branches     1773     1773           
=======================================
  Hits         6226     6226           
  Misses        409      409           
  Partials       11       11
Impacted Files Coverage Δ
components/drawer/index.tsx 98.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a3d96...7e0b81f. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13729   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         314      314           
  Lines        6646     6646           
  Branches     1773     1773           
=======================================
  Hits         6226     6226           
  Misses        409      409           
  Partials       11       11
Impacted Files Coverage Δ
components/drawer/index.tsx 98.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a3d96...7e0b81f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13729   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         314      314           
  Lines        6646     6646           
  Branches     1773     1773           
=======================================
  Hits         6226     6226           
  Misses        409      409           
  Partials       11       11
Impacted Files Coverage Δ
components/drawer/index.tsx 98.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a3d96...7e0b81f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #13729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13729   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         314      314           
  Lines        6646     6646           
  Branches     1773     1773           
=======================================
  Hits         6226     6226           
  Misses        409      409           
  Partials       11       11
Impacted Files Coverage Δ
components/drawer/index.tsx 98.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a3d96...7e0b81f. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Dec 20, 2018

Fixed in 1ac6b57

@afc163 afc163 closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants