New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hindi Locale #13759
Added Hindi Locale #13759
Conversation
Deploy preview for ant-design ready! Built with commit ce8459f |
a99fd51
to
c021223
Compare
|
@afc163 Here we go: react-component/pagination#158 |
a469163
to
4ff6cb4
Compare
@afc163 We needed this too react-component/calendar#466 😆 |
@afc163 Please tell me after you update calendar component's version |
|
276ed9d
to
ef55bd6
Compare
@afc163 Is it normal for these 3 tests to fail? |
nah , bro ! read comments. |
Which comments? |
You should add test like https://github.com/ant-design/ant-design/pull/13776/files#diff-52e85eb6b25a706f4e5d5dc78dfa04ac and run |
973f3a3
to
b8842bd
Compare
@afc163 Failing even after that. |
@gurungrahul2 Can you check what I missed? |
32325d6
to
ce8459f
Compare
@afc163 There were issues with my node env, things should be fine now. |
Codecov Report
@@ Coverage Diff @@
## feature #13759 +/- ##
==========================================
+ Coverage 94.1% 94.1% +<.1%
==========================================
Files 321 325 +4
Lines 7029 7038 +9
Branches 1778 1778
==========================================
+ Hits 6616 6625 +9
Misses 401 401
Partials 12 12
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## feature #13759 +/- ##
==========================================
+ Coverage 94.1% 94.1% +<.1%
==========================================
Files 321 325 +4
Lines 7029 7038 +9
Branches 1778 1778
==========================================
+ Hits 6616 6625 +9
Misses 401 401
Partials 12 12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## feature #13759 +/- ##
==========================================
+ Coverage 94.1% 94.1% +<.1%
==========================================
Files 321 325 +4
Lines 7029 7038 +9
Branches 1778 1778
==========================================
+ Hits 6616 6625 +9
Misses 401 401
Partials 12 12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## feature #13759 +/- ##
==========================================
+ Coverage 94.1% 94.1% +<.1%
==========================================
Files 321 325 +4
Lines 7029 7038 +9
Branches 1778 1778
==========================================
+ Hits 6616 6625 +9
Misses 401 401
Partials 12 12
Continue to review full report at Codecov.
|
@afc163 It's ready now |
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your pull request, thank you!
Fixes #13664
master
, feature for branchfeature
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :