Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hindi Locale #13759

Merged
merged 1 commit into from Dec 27, 2018
Merged

Added Hindi Locale #13759

merged 1 commit into from Dec 27, 2018

Conversation

aashutoshrathi
Copy link
Contributor

@aashutoshrathi aashutoshrathi commented Dec 21, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your pull request, thank you!
Fixes #13664

  • Make sure that you propose pull request to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a pull request to keep commit history clear.
  • Add some descriptions and refer relative issues for you pull request.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@netlify
Copy link

netlify bot commented Dec 21, 2018

Deploy preview for ant-design ready!

Built with commit ce8459f

https://deploy-preview-13759--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Dec 26, 2018

Cannot find module 'rc-pagination/lib/locale/hi_IN' from 'hi_IN.tsx'

@aashutoshrathi
Copy link
Contributor Author

@afc163 Here we go: react-component/pagination#158

@aashutoshrathi
Copy link
Contributor Author

@afc163 We needed this too react-component/calendar#466 😆

@aashutoshrathi
Copy link
Contributor Author

@afc163 Please tell me after you update calendar component's version

@afc163
Copy link
Member

afc163 commented Dec 26, 2018

rc-calendar@9.9.2

@aashutoshrathi
Copy link
Contributor Author

@afc163 Is it normal for these 3 tests to fail?

@rahgurung
Copy link
Contributor

@afc163 Is it normal for these 3 tests to fail?

nah , bro ! read comments.

@aashutoshrathi
Copy link
Contributor Author

Which comments?

@afc163
Copy link
Member

afc163 commented Dec 27, 2018

You should add test like https://github.com/ant-design/ant-design/pull/13776/files#diff-52e85eb6b25a706f4e5d5dc78dfa04ac and run npm test -- -u to update snapshots.

@aashutoshrathi
Copy link
Contributor Author

@afc163 Failing even after that.

@aashutoshrathi
Copy link
Contributor Author

@gurungrahul2 Can you check what I missed?

package.json Outdated Show resolved Hide resolved
@aashutoshrathi
Copy link
Contributor Author

@afc163 There were issues with my node env, things should be fine now.
Please check

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #13759 into feature will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           feature   #13759     +/-   ##
==========================================
+ Coverage     94.1%    94.1%   +<.1%     
==========================================
  Files          321      325      +4     
  Lines         7029     7038      +9     
  Branches      1778     1778             
==========================================
+ Hits          6616     6625      +9     
  Misses         401      401             
  Partials        12       12
Impacted Files Coverage Δ
components/calendar/locale/hi_IN.tsx 100% <100%> (ø)
components/time-picker/locale/hi_IN.tsx 100% <100%> (ø)
components/locale-provider/hi_IN.tsx 100% <100%> (ø)
components/date-picker/locale/hi_IN.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5483e2c...ce8459f. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #13759 into feature will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           feature   #13759     +/-   ##
==========================================
+ Coverage     94.1%    94.1%   +<.1%     
==========================================
  Files          321      325      +4     
  Lines         7029     7038      +9     
  Branches      1778     1778             
==========================================
+ Hits          6616     6625      +9     
  Misses         401      401             
  Partials        12       12
Impacted Files Coverage Δ
components/calendar/locale/hi_IN.tsx 100% <100%> (ø)
components/time-picker/locale/hi_IN.tsx 100% <100%> (ø)
components/locale-provider/hi_IN.tsx 100% <100%> (ø)
components/date-picker/locale/hi_IN.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5483e2c...ce8459f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #13759 into feature will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           feature   #13759     +/-   ##
==========================================
+ Coverage     94.1%    94.1%   +<.1%     
==========================================
  Files          321      325      +4     
  Lines         7029     7038      +9     
  Branches      1778     1778             
==========================================
+ Hits          6616     6625      +9     
  Misses         401      401             
  Partials        12       12
Impacted Files Coverage Δ
components/calendar/locale/hi_IN.tsx 100% <100%> (ø)
components/time-picker/locale/hi_IN.tsx 100% <100%> (ø)
components/locale-provider/hi_IN.tsx 100% <100%> (ø)
components/date-picker/locale/hi_IN.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5483e2c...ce8459f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #13759 into feature will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           feature   #13759     +/-   ##
==========================================
+ Coverage     94.1%    94.1%   +<.1%     
==========================================
  Files          321      325      +4     
  Lines         7029     7038      +9     
  Branches      1778     1778             
==========================================
+ Hits          6616     6625      +9     
  Misses         401      401             
  Partials        12       12
Impacted Files Coverage Δ
components/calendar/locale/hi_IN.tsx 100% <100%> (ø)
components/time-picker/locale/hi_IN.tsx 100% <100%> (ø)
components/locale-provider/hi_IN.tsx 100% <100%> (ø)
components/date-picker/locale/hi_IN.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5483e2c...ce8459f. Read the comment docs.

@aashutoshrathi
Copy link
Contributor Author

@afc163 It's ready now

@afc163 afc163 merged commit 0e42cbf into ant-design:feature Dec 27, 2018
@aashutoshrathi aashutoshrathi deleted the hindi branch December 27, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants