Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add alert-close-hover-color #13768

Merged
merged 1 commit into from Dec 21, 2018

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 21, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your pull request, thank you!

  • Make sure that you propose pull request to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a pull request to keep commit history clear.
  • Add some descriptions and refer relative issues for you pull request.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

elif isRefactor :

Introducing breaking-change?

  • Yes
  • No

Background information:

My company are theming ng-zorro-antd and it turns out some style declarations should be extracted to less variables for theming convenience.

@netlify
Copy link

netlify bot commented Dec 21, 2018

Deploy preview for ant-design ready!

Built with commit bfbb406

https://deploy-preview-13768--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #13768 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13768      +/-   ##
==========================================
- Coverage   93.75%   93.68%   -0.08%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1762     1765       +3     
==========================================
- Hits         6219     6214       -5     
- Misses        403      408       +5     
  Partials       11       11
Impacted Files Coverage Δ
components/_util/wave.tsx 84.84% <0%> (-3.04%) ⬇️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99b8a1...bfbb406. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #13768 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13768      +/-   ##
==========================================
- Coverage   93.75%   93.68%   -0.08%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1762     1765       +3     
==========================================
- Hits         6219     6214       -5     
- Misses        403      408       +5     
  Partials       11       11
Impacted Files Coverage Δ
components/_util/wave.tsx 84.84% <0%> (-3.04%) ⬇️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99b8a1...bfbb406. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #13768 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13768      +/-   ##
==========================================
- Coverage   93.75%   93.68%   -0.08%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1762     1765       +3     
==========================================
- Hits         6219     6214       -5     
- Misses        403      408       +5     
  Partials       11       11
Impacted Files Coverage Δ
components/_util/wave.tsx 84.84% <0%> (-3.04%) ⬇️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99b8a1...bfbb406. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #13768 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13768      +/-   ##
==========================================
- Coverage   93.75%   93.68%   -0.08%     
==========================================
  Files         314      314              
  Lines        6633     6633              
  Branches     1762     1765       +3     
==========================================
- Hits         6219     6214       -5     
- Misses        403      408       +5     
  Partials       11       11
Impacted Files Coverage Δ
components/_util/wave.tsx 84.84% <0%> (-3.04%) ⬇️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99b8a1...bfbb406. Read the comment docs.

@afc163 afc163 merged commit 96766d4 into ant-design:master Dec 21, 2018
@JLHwung JLHwung deleted the add-alert-close-hover-color branch December 21, 2018 12:01
@afc163 afc163 mentioned this pull request Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants