Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark lint #13906

Merged
merged 4 commits into from Dec 26, 2018
Merged

Add remark lint #13906

merged 4 commits into from Dec 26, 2018

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 26, 2018

Currently our remark lint is use default config on codacy.
Need adjust some rule to make the PR review check pass.

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #13906 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13906   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         315      315           
  Lines        6631     6631           
  Branches     1756     1724   -32     
=======================================
  Hits         6217     6217           
  Misses        403      403           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e30e2...10b74ea. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #13906 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13906   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         315      315           
  Lines        6631     6631           
  Branches     1756     1724   -32     
=======================================
  Hits         6217     6217           
  Misses        403      403           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e30e2...10b74ea. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #13906 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13906   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         315      315           
  Lines        6631     6631           
  Branches     1756     1724   -32     
=======================================
  Hits         6217     6217           
  Misses        403      403           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e30e2...10b74ea. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #13906 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13906      +/-   ##
==========================================
+ Coverage   93.75%    93.8%   +0.04%     
==========================================
  Files         315      315              
  Lines        6631     6631              
  Branches     1756     1724      -32     
==========================================
+ Hits         6217     6220       +3     
+ Misses        403      400       -3     
  Partials       11       11
Impacted Files Coverage Δ
components/_util/wave.tsx 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e30e2...6b686cb. Read the comment docs.

@netlify
Copy link

netlify bot commented Dec 26, 2018

Deploy preview for ant-design ready!

Built with commit 6b686cb

https://deploy-preview-13906--ant-design.netlify.com

@zombieJ
Copy link
Member Author

zombieJ commented Dec 26, 2018

Since rule severities of remark-lint are all warning, it's no need to add in pre-commit since it always pass.

package.json Outdated
@@ -233,7 +237,7 @@
],
"components/*/demo/*.md": [
"npm run lint-staged:demo"
]
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里会挂

@zombieJ zombieJ changed the title [WIP] Add remark lint Add remark lint Dec 26, 2018
@zombieJ zombieJ mentioned this pull request Dec 26, 2018
@@ -186,6 +189,7 @@
"lint": "npm run lint:ts && npm run lint:es && npm run lint:demo && npm run lint:style",
"lint:ts": "npm run tsc && antd-tools run ts-lint",
"lint:es": "eslint tests site scripts components ./.*.js ./webpack.config.js --ext '.js,.jsx'",
"lint:md": "remark components/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint-staged 也加一个吧

@zombieJ zombieJ merged commit bf087e2 into master Dec 26, 2018
@zombieJ zombieJ deleted the remark-lint branch December 26, 2018 06:15
@afc163 afc163 mentioned this pull request Apr 21, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants