New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remark lint #13906
Add remark lint #13906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13906 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 315 315
Lines 6631 6631
Branches 1756 1724 -32
=======================================
Hits 6217 6217
Misses 403 403
Partials 11 11 Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #13906 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 315 315
Lines 6631 6631
Branches 1756 1724 -32
=======================================
Hits 6217 6217
Misses 403 403
Partials 11 11 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #13906 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 315 315
Lines 6631 6631
Branches 1756 1724 -32
=======================================
Hits 6217 6217
Misses 403 403
Partials 11 11 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
+ Coverage 93.75% 93.8% +0.04%
==========================================
Files 315 315
Lines 6631 6631
Branches 1756 1724 -32
==========================================
+ Hits 6217 6220 +3
+ Misses 403 400 -3
Partials 11 11
Continue to review full report at Codecov.
|
Deploy preview for ant-design ready! Built with commit 6b686cb |
Since rule severities of remark-lint are all |
package.json
Outdated
@@ -233,7 +237,7 @@ | |||
], | |||
"components/*/demo/*.md": [ | |||
"npm run lint-staged:demo" | |||
] | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里会挂
@@ -186,6 +189,7 @@ | |||
"lint": "npm run lint:ts && npm run lint:es && npm run lint:demo && npm run lint:style", | |||
"lint:ts": "npm run tsc && antd-tools run ts-lint", | |||
"lint:es": "eslint tests site scripts components ./.*.js ./webpack.config.js --ext '.js,.jsx'", | |||
"lint:md": "remark components/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint-staged 也加一个吧
Currently our remark lint is use default config on codacy.
Need adjust some rule to make the PR review check pass.