Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-label on Icon component to enhance accessibility #14258

Merged
merged 3 commits into from Jan 10, 2019
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 10, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Add aria-label on Icon component to enhance accessibility:
kapture 2019-01-10 at 18 44 45

API Realization (Optional if not new feature)

Internal update.

What's the effect? (Optional if not new feature)

Add aria-label on Icon component i element to makes icon readable

Changelog description (Optional if not new feature)

  • Icon component add aria-label prop to enhance accessibility
  • Icon 组件添加 aria-label 属性以提升无障碍体验

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ zombieJ changed the title Icon aria Add aria-label on Icon component to enhance accessibility Jan 10, 2019
@zombieJ zombieJ requested a review from afc163 January 10, 2019 10:56
@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #14258 into feature will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #14258      +/-   ##
===========================================
+ Coverage     94.2%   94.24%   +0.04%     
===========================================
  Files          330      330              
  Lines         7212     7217       +5     
  Branches      1814     1812       -2     
===========================================
+ Hits          6794     6802       +8     
+ Misses         405      402       -3     
  Partials        13       13
Impacted Files Coverage Δ
components/locale-provider/default.tsx 100% <ø> (ø) ⬆️
components/locale-provider/zh_CN.tsx 100% <ø> (ø) ⬆️
components/icon/index.tsx 89.47% <100%> (+1.01%) ⬆️
components/_util/wave.tsx 87.73% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef4d72...ad56920. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #14258 into feature will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #14258      +/-   ##
===========================================
+ Coverage     94.2%   94.24%   +0.04%     
===========================================
  Files          330      330              
  Lines         7212     7217       +5     
  Branches      1814     1812       -2     
===========================================
+ Hits          6794     6802       +8     
+ Misses         405      402       -3     
  Partials        13       13
Impacted Files Coverage Δ
components/locale-provider/default.tsx 100% <ø> (ø) ⬆️
components/locale-provider/zh_CN.tsx 100% <ø> (ø) ⬆️
components/icon/index.tsx 89.47% <100%> (+1.01%) ⬆️
components/_util/wave.tsx 87.73% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef4d72...ad56920. Read the comment docs.

@netlify
Copy link

netlify bot commented Jan 10, 2019

Deploy preview for ant-design ready!

Built with commit ad56920

https://deploy-preview-14258--ant-design.netlify.com

@afc163 afc163 merged commit 8f9f584 into feature Jan 10, 2019
@afc163 afc163 deleted the icon-aria branch January 10, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants