Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix IE 11 bug" #14765

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@Shub1427
Copy link
Contributor

commented Feb 10, 2019

Reverts #14602

Due to this change, long descriptions break in browsers. Detailed discussions on why this revert is made can be found here.

Revert "fix IE 11 bug"
This reverts commit 7d7de2a.
@netlify

This comment has been minimized.

Copy link

commented Feb 10, 2019

Deploy preview for ant-design failed.

Built with commit f3edb21

https://app.netlify.com/sites/ant-design/deploys/5c5fd2d897555b0008a71da8

@codecov

This comment has been minimized.

Copy link

commented Feb 10, 2019

Codecov Report

Merging #14765 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14765      +/-   ##
==========================================
- Coverage   92.74%    92.7%   -0.05%     
==========================================
  Files         236      236              
  Lines        6220     6220              
  Branches     1852     1835      -17     
==========================================
- Hits         5769     5766       -3     
- Misses        448      453       +5     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dee5c5...f3edb21. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 10, 2019

Codecov Report

Merging #14765 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14765      +/-   ##
==========================================
- Coverage   92.74%    92.7%   -0.05%     
==========================================
  Files         236      236              
  Lines        6220     6220              
  Branches     1852     1835      -17     
==========================================
- Hits         5769     5766       -3     
- Misses        448      453       +5     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dee5c5...f3edb21. Read the comment docs.

@zombieJ zombieJ merged commit 57f4c62 into ant-design:master Feb 10, 2019

23 of 28 checks passed

Header rules Deploy failed
Details
Mixed content Deploy failed
Details
Pages changed Deploy failed
Details
Redirect rules Deploy failed
Details
deploy/netlify Deploy preview failed.
Details
AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2dee5c5...f3edb21
Details
codecov/project 92.7% (-0.05%) compared to 2dee5c5
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@Shub1427 Shub1427 deleted the Shub1427:revert-14602-patch-1 branch Feb 11, 2019

ruoqianfengshao added a commit to ruoqianfengshao/ant-design that referenced this pull request Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.