Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: lift up coverage rate #15293

Merged
merged 28 commits into from Mar 25, 2019
Merged

pref: lift up coverage rate #15293

merged 28 commits into from Mar 25, 2019

Conversation

orzyyyy
Copy link
Contributor

@orzyyyy orzyyyy commented Mar 8, 2019

Related to #14775.

@netlify
Copy link

netlify bot commented Mar 8, 2019

Deploy preview for ant-design ready!

Built with commit c1bfa0d

https://deploy-preview-15293--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #15293 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15293      +/-   ##
==========================================
+ Coverage   94.18%    94.3%   +0.12%     
==========================================
  Files         250      250              
  Lines        6635     6635              
  Branches     1938     1906      -32     
==========================================
+ Hits         6249     6257       +8     
+ Misses        385      377       -8     
  Partials        1        1
Impacted Files Coverage Δ
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️
components/calendar/Header.tsx 94.93% <0%> (+12.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b95d0...c783e29. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #15293 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15293      +/-   ##
==========================================
+ Coverage   94.44%   95.06%   +0.61%     
==========================================
  Files         250      250              
  Lines        6645     6643       -2     
  Branches     1943     1907      -36     
==========================================
+ Hits         6276     6315      +39     
+ Misses        368      327      -41     
  Partials        1        1
Impacted Files Coverage Δ
components/card/index.tsx 98.63% <ø> (+14.63%) ⬆️
components/calendar/Header.tsx 96.2% <100%> (+8.86%) ⬆️
components/_util/wave.tsx 85.57% <0%> (+0.96%) ⬆️
components/affix/index.tsx 91.54% <0%> (+2.81%) ⬆️
components/mention/index.tsx 88.37% <0%> (+4.65%) ⬆️
components/upload/Upload.tsx 94.26% <0%> (+5.73%) ⬆️
components/tabs/index.tsx 96.77% <0%> (+6.45%) ⬆️
components/menu/index.tsx 98.13% <0%> (+6.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 788292c...c1bfa0d. Read the comment docs.

@orzyyyy
Copy link
Contributor Author

orzyyyy commented Mar 9, 2019

@orzyyyy orzyyyy marked this pull request as ready for review March 12, 2019 03:27
@orzyyyy orzyyyy changed the title pref: lift up coverage rate [WIP] pref: lift up coverage rate Mar 15, 2019
@orzyyyy orzyyyy changed the title [WIP] pref: lift up coverage rate pref: lift up coverage rate Mar 15, 2019
components/_util/wave.tsx Outdated Show resolved Hide resolved
@orzyyyy
Copy link
Contributor Author

orzyyyy commented Mar 25, 2019

这 pr 冲突到蛋疼...啥时候能合了?

@afc163 afc163 merged commit cfa6e26 into ant-design:master Mar 25, 2019
@orzyyyy orzyyyy deleted the issue-14775 branch March 25, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants