Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add click prop for BreadcrumbItem #15331

Merged

Conversation

tgxpuisb
Copy link

@tgxpuisb tgxpuisb commented Mar 11, 2019

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

👻 需求背景

为Breadcrumb.Item组件增加onClick事件的申明,虽然大多数时候Breadcrumb.Item会配合自身的href或者嵌套与route相关的路由标签使用,但是有些时候还是需要为Breadcrumb.Item绑定一些单独的逻辑处理事件的
image
此时就就会出现如果所示的情况,查询解决方案有在Breadcrumb.Item标签里面写一个

元素再进行绑定,但是那样会多出一个元素,于是决定为Breadcrumb.Item添加一个可以写onClick属性的申明

💡 解决方案和最终实现是?

image

📝 更新日志怎么写?

从用户角度描述具体变化,以及可能的 breaking change 和其他风险?

无breaking change风险

  1. 英文描述
    add onClick prop for BreadcrumbItem (typescript)

  2. 中文描述(可选)

☑️ 请求合并前的自查清单

  • 文档无须补充
  • 代码演示无须提供
  • TypeScript 定义已补充

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ant-design ready!

Built with commit 34a9da6

https://deploy-preview-15331--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #15331 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15331      +/-   ##
==========================================
- Coverage   94.14%    94.1%   -0.04%     
==========================================
  Files         250      250              
  Lines        6643     6637       -6     
  Branches     1939     1940       +1     
==========================================
- Hits         6254     6246       -8     
- Misses        388      390       +2     
  Partials        1        1
Impacted Files Coverage Δ
components/breadcrumb/BreadcrumbItem.tsx 100% <ø> (ø) ⬆️
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️
components/list/index.tsx 97.26% <0%> (ø) ⬆️
components/list/Item.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e82879...34a9da6. Read the comment docs.

@afc163 afc163 merged commit 753cb42 into ant-design:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants