Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tabs): onTabClick description #15420

Merged
merged 2 commits into from
Mar 15, 2019
Merged

docs(tabs): onTabClick description #15420

merged 2 commits into from
Mar 15, 2019

Conversation

akaguny
Copy link
Contributor

@akaguny akaguny commented Mar 14, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

to small informaion about tabs api

馃挕 Solution

  • onTabClick collback description provided by rc-tabs
  • link to rc-tabs docs (for read more)

馃摑 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

* onTabClick collback description provided by rc-tabs
* link to rc-tabs docs (for read more)
@netlify
Copy link

netlify bot commented Mar 14, 2019

Deploy preview for ant-design ready!

Built with commit 59a6d49

https://deploy-preview-15420--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #15420 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15420      +/-   ##
==========================================
+ Coverage   94.19%   94.23%   +0.04%     
==========================================
  Files         250      250              
  Lines        6647     6647              
  Branches     1910     1942      +32     
==========================================
+ Hits         6261     6264       +3     
+ Misses        385      382       -3     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 87.5% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4f0e6e6...ef1fc4a. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #15420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15420   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         250      250           
  Lines        6647     6647           
  Branches     1910     1910           
=======================================
  Hits         6261     6261           
  Misses        385      385           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4f0e6e6...59a6d49. Read the comment docs.

@@ -45,3 +46,4 @@ Ant Design has 3 types of Tabs for different situations.
| forceRender | Forced render of content in tabs, not lazy render after clicking on tabs | boolean | false |
| key | TabPane's key | string | - |
| tab | Show text in TabPane's head | string\|ReactNode | - |
More option at [rc-tabs option](https://github.com/react-component/tabs#tabpane)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a blank line before this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep markdown source clear and readable too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future maybe prettier for this?

@afc163 afc163 merged commit 785820e into ant-design:master Mar 15, 2019
@akaguny akaguny deleted the patch-1 branch March 16, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants