-
-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tabs): onTabClick description #15420
Conversation
* onTabClick collback description provided by rc-tabs * link to rc-tabs docs (for read more)
Deploy preview for ant-design ready! Built with commit 59a6d49 |
Codecov Report
@@ Coverage Diff @@
## master #15420 +/- ##
==========================================
+ Coverage 94.19% 94.23% +0.04%
==========================================
Files 250 250
Lines 6647 6647
Branches 1910 1942 +32
==========================================
+ Hits 6261 6264 +3
+ Misses 385 382 -3
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15420 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 250 250
Lines 6647 6647
Branches 1910 1910
=======================================
Hits 6261 6261
Misses 385 385
Partials 1 1 Continue to review full report at Codecov.
|
@@ -45,3 +46,4 @@ Ant Design has 3 types of Tabs for different situations. | |||
| forceRender | Forced render of content in tabs, not lazy render after clicking on tabs | boolean | false | | |||
| key | TabPane's key | string | - | | |||
| tab | Show text in TabPane's head | string\|ReactNode | - | | |||
More option at [rc-tabs option](https://github.com/react-component/tabs#tabpane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a blank line before this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add blank line after table https://deploy-preview-15420--ant-design.netlify.com/components/tabs/#header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep markdown source clear and readable too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future maybe prettier for this?
馃 This is a ...
馃懟 What's the background?
to small informaion about tabs api
馃挕 Solution
馃摑 Changelog description
English description
Chinese description (optional)
鈽戯笍 Self Check before Merge