Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearTimeout #15434

Merged
merged 2 commits into from
Mar 15, 2019
Merged

fix: clearTimeout #15434

merged 2 commits into from
Mar 15, 2019

Conversation

chiaweilee
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • [ x ] Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method. in BookInfo (created by Route)

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario.

💡 Solution

use clearTimeout

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

clear Timeout on willUnmount

  1. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • [ x ] Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 15, 2019

Deploy preview for ant-design ready!

Built with commit 72296fd

https://deploy-preview-15434--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Mar 15, 2019

image

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #15434 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15434      +/-   ##
==========================================
+ Coverage   94.19%   94.23%   +0.04%     
==========================================
  Files         250      250              
  Lines        6647     6647              
  Branches     1910     1942      +32     
==========================================
+ Hits         6261     6264       +3     
+ Misses        385      382       -3     
  Partials        1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0298ba...72296fd. Read the comment docs.

@afc163 afc163 merged commit 4aa32b9 into ant-design:master Mar 15, 2019
@chiaweilee chiaweilee deleted the patch-1 branch March 16, 2019 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants