Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English translation for notFoundContent #15453

Merged
merged 1 commit into from
Mar 16, 2019
Merged

English translation for notFoundContent #15453

merged 1 commit into from
Mar 16, 2019

Conversation

SamKirkland
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.
    component, notFoundContent default value will now be in english.
    Code Sandbox link example

  2. Describe the problem and the scenario.
    type @somethingthatwontbematched

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
    When using a component, when no matches are found the default message will now be in english instead of chinese.

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 16, 2019

Deploy preview for ant-design ready!

Built with commit e35f93f

https://deploy-preview-15453--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #15453 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15453      +/-   ##
==========================================
+ Coverage   94.25%   94.28%   +0.03%     
==========================================
  Files         250      250              
  Lines        6653     6653              
  Branches     1914     1914              
==========================================
+ Hits         6271     6273       +2     
+ Misses        381      379       -2     
  Partials        1        1
Impacted Files Coverage Δ
components/mention/index.tsx 83.72% <ø> (ø) ⬆️
components/upload/UploadList.tsx 96.33% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40c0d3...e35f93f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #15453 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15453      +/-   ##
==========================================
+ Coverage   94.25%   94.28%   +0.03%     
==========================================
  Files         250      250              
  Lines        6653     6653              
  Branches     1914     1914              
==========================================
+ Hits         6271     6273       +2     
+ Misses        381      379       -2     
  Partials        1        1
Impacted Files Coverage Δ
components/mention/index.tsx 83.72% <ø> (ø) ⬆️
components/upload/UploadList.tsx 96.33% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40c0d3...e35f93f. Read the comment docs.

@afc163 afc163 merged commit 5d96ba6 into ant-design:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants