Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put description in PR template into comment #15513

Merged
merged 1 commit into from Mar 21, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

这样提交后这些信息不会展示到 PR 里。

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title 📝 put description in PR template into comment Put description in PR template into comment Mar 19, 2019
@netlify
Copy link

netlify bot commented Mar 19, 2019

Deploy preview for ant-design ready!

Built with commit b310697

https://deploy-preview-15513--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #15513 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15513   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files         250      250           
  Lines        6653     6653           
  Branches     1949     1914   -35     
=======================================
  Hits         6277     6277           
  Misses        375      375           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6b3a3...b310697. Read the comment docs.

@dengfuping dengfuping self-requested a review March 21, 2019 02:13
@dengfuping dengfuping merged commit c8a3266 into master Mar 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the optimize-pr-template branch March 21, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants