Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underlines from focused links #15759

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Conversation

Nouzbe
Copy link
Contributor

@Nouzbe Nouzbe commented Mar 30, 2019

This is a ...

  • Component style update

What's the background?

This PR removes underlines from focused links.
It avoids an appearing/disappearing underline when hovering a focused link.
See #15725.

API Realization

The API is unchanged.

What's the affect?

Focused links are not underlined.

Self Check before Merge

  • Doc not needed
  • Demo not needed
  • TypeScript definition not needed
  • Changelog provided (just above)

Additional Plan?

No.

@netlify
Copy link

netlify bot commented Mar 30, 2019

Deploy preview for ant-design ready!

Built with commit 765dcc3

https://deploy-preview-15759--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #15759 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15759      +/-   ##
==========================================
+ Coverage   94.96%   95.03%   +0.06%     
==========================================
  Files         250      250              
  Lines        6640     6640              
  Branches     1907     1907              
==========================================
+ Hits         6306     6310       +4     
+ Misses        333      329       -4     
  Partials        1        1
Impacted Files Coverage Δ
components/form/FormItem.tsx 98.85% <0%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56d651...765dcc3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #15759 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15759      +/-   ##
==========================================
+ Coverage   94.96%   95.03%   +0.06%     
==========================================
  Files         250      250              
  Lines        6640     6640              
  Branches     1907     1907              
==========================================
+ Hits         6306     6310       +4     
+ Misses        333      329       -4     
  Partials        1        1
Impacted Files Coverage Δ
components/form/FormItem.tsx 98.85% <0%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56d651...765dcc3. Read the comment docs.

@afc163 afc163 merged commit f55ccfe into ant-design:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants