New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Print reject error when ActionButton catch promise rejects #16437
Conversation
Deploy preview for ant-design ready! Built with commit db5da92 |
Codecov Report
@@ Coverage Diff @@
## master #16437 +/- ##
==========================================
- Coverage 95.71% 95.69% -0.02%
==========================================
Files 257 257
Lines 7068 7069 +1
Branches 2002 1965 -37
==========================================
Hits 6765 6765
- Misses 302 303 +1
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16437 +/- ##
==========================================
+ Coverage 95.65% 95.68% +0.02%
==========================================
Files 258 258
Lines 7107 7108 +1
Branches 1992 1968 -24
==========================================
+ Hits 6798 6801 +3
+ Misses 307 305 -2
Partials 2 2
Continue to review full report at Codecov.
|
具体场景主要是 Modal.comfirm 组件的 |
所有使用
|
来个 Test Case 如何? |
好的👌明天补上 |
@afc163 已经补上测试用例,麻烦帮忙 review 一下哈 |
🤔 This is a ...
👻 What's the background?
There is nothing output on browser console when an error occurs while
<Modal>
components callonOk
callback function.💡 Solution
Emit error manually by add
console.error(e)
📝 Changelog
Modal
'sonOk
callback retures an promise rejectsActionButton
捕获到 Promise 的 Reject 的时候,打印错误。Modal
组件onOk
回调返回的 Promise 被 Reject 的时候,打印错误。☑️ Self Check before Merge