Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codesandbox not support slash import #16509

Merged
merged 2 commits into from May 10, 2019
Merged

fix: codesandbox not support slash import #16509

merged 2 commits into from May 10, 2019

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented May 9, 2019

Close #16514.

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

https://ant.design/components/select-cn/#components-select-demo-select-users

image


View rendered components/select/demo/select-users.md
View rendered components/transfer/demo/table-transfer.md

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #16509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16509   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7120     7120           
  Branches     1970     1994   +24     
=======================================
  Hits         6815     6815           
  Misses        303      303           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bfecc3...cb30ad8. Read the comment docs.

@netlify
Copy link

netlify bot commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit cb30ad8

https://deploy-preview-16509--ant-design.netlify.com

@@ -15,7 +15,7 @@ A complete multiple select sample with remote search, debounce fetch, ajax callb

```jsx
import { Select, Spin } from 'antd';
import debounce from 'lodash/debounce';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么不改成 import debounce from 'lodash.debounce'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

想了下,这样增加不少依赖,每使用一个就得加一个。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import debounce from 'lodash/debounce'; 体积小很多,推荐这么写。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codesandbox 的问题要想个别的办法解决。

Copy link
Member

@yesmeck yesmeck May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有 lodash 的话,直接把 lodash external 出来

@zombieJ
Copy link
Member

zombieJ commented May 10, 2019

修好,这个 issue 可以一起处理了 #16514

@ycjcl868
Copy link
Contributor Author

image

@ycjcl868 ycjcl868 changed the title fix: codesandbox not support lodash/* fix: codesandbox not support slash import May 10, 2019
@afc163
Copy link
Member

afc163 commented May 10, 2019

顺便看看 #16514

@ycjcl868
Copy link
Contributor Author

@ycjcl868
Copy link
Contributor Author

发现了另一个问题,List 的加载无限会有空白

image

@zombieJ
Copy link
Member

zombieJ commented May 10, 2019

原本例子问题另起讨论,这个解决了就可以合了。

@zombieJ zombieJ merged commit 0156886 into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-select-demo branch May 10, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Component: Infinite & virtualized: This example on CodePen and CodeSandbox can not run
5 participants