Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added 2 variables to flexibly control the background of the table cells #16843

Merged
merged 1 commit into from Jun 3, 2019

Conversation

alxkosov
Copy link
Contributor

@alxkosov alxkosov commented May 28, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

  1. Describe the source of requirement, like related issue link.
    added 2 variables to flexibly control the background of the table cells when the row is selected and the sorting column is active
  2. Describe the problem and the scenario.
    the background of the cells of the selected row changed during the hover and for the cell of the column by which the sorting was performed

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@alxkosov
Copy link
Contributor Author

@alxkosov alxkosov commented May 28, 2019

image

@netlify
Copy link

@netlify netlify bot commented May 28, 2019

Deploy preview for ant-design ready!

Built with commit 4f29b2b4886533c3915605c0f080e86a24ace13f

https://deploy-preview-16843--ant-design.netlify.com

@zombieJ
Copy link
Member

@zombieJ zombieJ commented May 28, 2019

CI broken. Try to rebase feature branch.

@alxkosov alxkosov force-pushed the add-table-customize-variable branch from 789427a to 4f29b2b Compare May 29, 2019
@akaguny
Copy link
Contributor

@akaguny akaguny commented May 30, 2019

@zombieJ , pls help us with ci

@alxkosov alxkosov force-pushed the add-table-customize-variable branch from 4f29b2b to 3def003 Compare May 31, 2019
@codecov
Copy link

@codecov codecov bot commented May 31, 2019

Codecov Report

Merging #16843 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16843   +/-   ##
========================================
  Coverage    95.96%   95.96%           
========================================
  Files          263      263           
  Lines         7329     7329           
  Branches      2008     2046   +38     
========================================
  Hits          7033     7033           
  Misses         294      294           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 96f172f...3def003. Read the comment docs.

1 similar comment
@codecov
Copy link

@codecov codecov bot commented May 31, 2019

Codecov Report

Merging #16843 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16843   +/-   ##
========================================
  Coverage    95.96%   95.96%           
========================================
  Files          263      263           
  Lines         7329     7329           
  Branches      2008     2046   +38     
========================================
  Hits          7033     7033           
  Misses         294      294           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 96f172f...3def003. Read the comment docs.

zombieJ
zombieJ approved these changes Jun 3, 2019
@zombieJ zombieJ changed the title Added 2 variables to flexibly control the background of the table cells feat: Added 2 variables to flexibly control the background of the table cells Jun 3, 2019
@zombieJ zombieJ merged commit fb6d629 into ant-design:feature Jun 3, 2019
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants