Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update rc-drawer version to fix afterVisibleChange issue #17311

Merged
merged 2 commits into from Jun 26, 2019

Conversation

Projects
None yet
2 participants
@jljsj33
Copy link
Member

commented Jun 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复在 Edge 下关闭后没有调用 afterVisibleChange,#17303

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 26, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 26, 2019

Deploy preview for ant-design ready!

Built with commit dae1ab9

https://deploy-preview-17311--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

ci failed

@jljsj33 jljsj33 changed the title Update rc-drawer version Update: rc-drawer version Jun 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #17311 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17311   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2015     2053   +38     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage Δ
components/drawer/index.tsx 98.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94072ad...dae1ab9. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

changelog 和标题都写一下。

#17303

@jljsj33 jljsj33 changed the title Update: rc-drawer version chore: Update rc-drawer version Jun 26, 2019

@afc163 afc163 changed the title chore: Update rc-drawer version chore: Update rc-drawer version to fix afterVisibleChange issue Jun 26, 2019

@afc163 afc163 merged commit 000757d into master Jun 26, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.95%)
Details
codecov/project 95.95% (+0%) compared to 94072ad
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 26, 2019

@delete-merged-branch delete-merged-branch bot deleted the jljsj33-patch-1 branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.