chore: Extract SwitchChangeEventHandler and SwitchSize #17331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we can define change handler more convenience:
Before:
```javascript
const handleChange = (checked: boolean, event: MouseEvent) => {
...
}
```
After:
```javascript
const handleChange: SwitchChangeEventHandler = (checked, event) => {
...
}
```
|
Deploy preview for ant-design ready! Built with commit 87afda5 |
afc163
reviewed
Jun 27, 2019
| export interface SwitchProps { | ||
| prefixCls?: string; | ||
| size?: 'small' | 'default'; |
There was a problem hiding this comment.
export enum SwitchSize {
SMALL = 'small';
DEFAUL = 'default';
}import { SwitchSize } from 'antd/es/switch';
<Switch size={SwitchSize.SMALL} />There was a problem hiding this comment.
这样就改使用方式了。
目前看来最好的方式是：#7965 (comment)
There was a problem hiding this comment.
他那种assert不推荐的，毕竟assert能少用就少用。如果值A是B类型，你应该直接声明A是B类型，而不是把A里的类型都assert成B里的属性然后通过ts的类型检查。
afc163
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can define a change handler more convenience:
Before:
After:
🤔 This is a ...
👻 What's the background?
💡 Solution
📝 Changelog
☑️ Self Check before Merge