feat: add Breadcrumb.Separator #17873

quicksand-1 · 2019-07-25T04:07:30Z

🤔 这个变动的性质是？

🔗 相关 Issue

close #17812

💡 需求背景和解决方案

需求背景

在使用 Breadcrumb.Item 需要自定义 separator 时，Item 组件会被父组件覆盖。如需要渲染一下样式：
- 当前位置：xxx / xxx / xxx

解决方案

新增 Breadcrumb.Separator 组件进行 separator 的自定义。

📝 更新日志怎么写？

语言	更新描述
🇺🇸 英文
🇨🇳 中文	新增了 Breadcrumb.Separator 组件，可进行 separator 自定义

☑️ 请求合并前的自查清单

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
Changelog 已提供或无须提供

View rendered components/breadcrumb/demo/separator-1.md

netlify · 2019-07-25T04:07:42Z

Deploy preview for ant-design ready!

Built with commit b91dcd5

https://deploy-preview-17873--ant-design.netlify.com

afc163 · 2019-07-30T10:17:15Z

components/breadcrumb/demo/separator.md

-    <Breadcrumb.Item>Home</Breadcrumb.Item>
+  <Breadcrumb>
+    <Breadcrumb.Item separator=":">Location</Breadcrumb.Item>
+    <Breadcrumb.Item separator="---">Home</Breadcrumb.Item>


不要支持这种用法。

Item 不支持 separator 的考虑是什么呢？
我发现新增一个 Breadcrumb.Separator 改动量很大。如果仅仅需要让 Item 支持自定义的 separator 属性，只需要改如下图所示的代码即可。

最好只推荐一种使用方式，否则 <Breadcrumb.Item separator=":" /> 和 <Breadcrumb.Separator>:</Breadcrumb.Separator> 两个写法完全等效，共存没什么意义。

是的，在最开始的时候，我在设计 Breadcrumb.Separator 组件的时候，发现也需要改其他文件的代码，且改动量不小。所以最终决定使用 <Breadcrumb.Item separator=":" /> 。

从语义上来说 Breadcrumb.Separator 好很多。

codecov · 2019-07-31T03:00:04Z

Codecov Report

Merging #17873 into feature will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           feature   #17873      +/-   ##
===========================================
+ Coverage    96.12%   96.12%   +<.01%     
===========================================
  Files          271      272       +1     
  Lines         7478     7489      +11     
  Branches      2052     2056       +4     
===========================================
+ Hits          7188     7199      +11     
  Misses         288      288              
  Partials         2        2

Impacted Files	Coverage Δ
components/breadcrumb/index.tsx	`100% <100%> (ø)`	⬆️
components/breadcrumb/Breadcrumb.tsx	`96.66% <100%> (+0.05%)`	⬆️
components/breadcrumb/BreadcrumbSeparator.tsx	`100% <100%> (ø)`
components/breadcrumb/BreadcrumbItem.tsx	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8479a7d...06e2e1a. Read the comment docs.

codecov · 2019-07-31T03:00:04Z

Codecov Report

Merging #17873 into feature will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           feature   #17873      +/-   ##
===========================================
+ Coverage    96.12%   96.12%   +<.01%     
===========================================
  Files          271      272       +1     
  Lines         7478     7489      +11     
  Branches      2052     2099      +47     
===========================================
+ Hits          7188     7199      +11     
  Misses         288      288              
  Partials         2        2

Impacted Files	Coverage Δ
components/breadcrumb/index.tsx	`100% <100%> (ø)`	⬆️
components/breadcrumb/Breadcrumb.tsx	`96.66% <100%> (+0.05%)`	⬆️
components/breadcrumb/BreadcrumbSeparator.tsx	`100% <100%> (ø)`
components/breadcrumb/BreadcrumbItem.tsx	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8479a7d...b91dcd5. Read the comment docs.

afc163 · 2019-07-31T03:07:10Z

components/breadcrumb/demo/separator-1.md

+  </Breadcrumb>,
+  mountNode,
+);
+```


separator-1.md => separator-indepent.md

afc163 · 2019-07-31T03:07:32Z

components/breadcrumb/index.zh-CN.md

+| ------- | -------------- | -------------------------------------- | ------ | ------ |
+| href    | 链接的目的地   | string                                 | -      | 3.17.0 |
+| overlay | 下拉菜单的内容 | [Menu](/components/menu) \| () => Menu | -      | 3.17.0 |
+| onClick | 单击事件       | (e:MouseEvent)=>void                   | -      | 3.17.0 |

 ### routes


文档里要加一下 Breadcrumb.Separator 的说明。

说明的表格中的“版本”字段该如何填写？

3.21.0 好了，赶上车这个月底就发了。

afc163 · 2019-07-31T06:18:30Z

components/breadcrumb/index.zh-CN.md

@@ -32,6 +32,14 @@ title: Breadcrumb
 | overlay | 下拉菜单的内容 | [Menu](/components/menu) \| () => Menu | -      | 3.17.0 |
 | onClick | 单击事件       | (e:MouseEvent)=>void                   | -      | 3.17.0 |

+### Breadcrumb.Separator


可以在这后面标一个 3.21.0

语义化提交或者 PR 标题有规范吗？这个 PR 提交还需要修改吗❓

Suggested change

### Breadcrumb.Separator

### Breadcrumb.Separator `3.21.0`

add Breadcrumb.Separator

4a8affe

pr-triage bot added the PR: unreviewed label Jul 25, 2019

quicksand-1 mentioned this pull request Jul 29, 2019

BreadcrumbItem的separator被父组件覆盖 #17812

Closed

1 task

afc163 reviewed Jul 30, 2019

View reviewed changes

Breadcrumb.Separator checks

06e2e1a

afc163 reviewed Jul 31, 2019

View reviewed changes

components/breadcrumb/demo/separator-1.md Outdated

</Breadcrumb>,

mountNode,

);

```

Copy link

Member

afc163 Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separator-1.md => separator-indepent.md

afc163 reviewed Jul 31, 2019

View reviewed changes

chenlong added 2 commits July 31, 2019 15:00

Breadcrumb. Separator add description

188f408

update breadcrumb/index.zh-CN.md

b91dcd5

afc163 approved these changes Aug 1, 2019

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Aug 1, 2019

afc163 changed the title ~~add Breadcrumb.Separator~~ feat: add Breadcrumb.Separator Aug 1, 2019

afc163 merged commit 36db887 into ant-design:feature Aug 2, 2019

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Aug 2, 2019

ikobe-zz mentioned this pull request Aug 4, 2019

docs: 3.21.0 changelog #18071

Merged

14 tasks

snyk-bot mentioned this pull request Aug 14, 2019

[Snyk] Upgrade antd from 3.13.6 to 3.21.2 Watemlifts/redash#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Breadcrumb.Separator #17873

feat: add Breadcrumb.Separator #17873

quicksand-1 commented Jul 25, 2019 •

edited by afc163

netlify bot commented Jul 25, 2019 •

edited

afc163 Jul 30, 2019

quicksand-1 Jul 30, 2019

afc163 Jul 30, 2019 •

edited

quicksand-1 Jul 30, 2019

afc163 Jul 30, 2019

codecov bot commented Jul 31, 2019

codecov bot commented Jul 31, 2019 •

edited

afc163 Jul 31, 2019

afc163 Jul 31, 2019

quicksand-1 Jul 31, 2019

afc163 Jul 31, 2019

quicksand-1 Jul 31, 2019

afc163 Jul 31, 2019

afc163 Jul 31, 2019

quicksand-1 Aug 1, 2019

afc163 Aug 1, 2019

quicksand-1 Aug 1, 2019

feat: add Breadcrumb.Separator #17873

feat: add Breadcrumb.Separator #17873

Conversation

quicksand-1 commented Jul 25, 2019 • edited by afc163

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

需求背景

解决方案

📝 更新日志怎么写？

☑️ 请求合并前的自查清单

netlify bot commented Jul 25, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afc163 Jul 30, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 31, 2019

Codecov Report

codecov bot commented Jul 31, 2019 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quicksand-1 commented Jul 25, 2019 •

edited by afc163

netlify bot commented Jul 25, 2019 •

edited

afc163 Jul 30, 2019 •

edited

codecov bot commented Jul 31, 2019 •

edited