Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip not work with disabled checkbox #18138

Merged
merged 1 commit into from Aug 7, 2019

Conversation

laysent
Copy link
Contributor

@laysent laysent commented Aug 7, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18137

💡 Background and solution

Add similar logic as for Button and Switch.

📝 Changelog

Language Changelog
🇺🇸 English Fix Tooltip not work correctly on disabled Checkbox
🇨🇳 Chinese 修复 Tooltip 在 disabled Checkbox 上不能正确工作的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 7, 2019

Deploy preview for ant-design ready!

Built with commit 7ca85ad

https://deploy-preview-18138--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #18138 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18138      +/-   ##
==========================================
+ Coverage   96.15%   96.15%   +<.01%     
==========================================
  Files         276      276              
  Lines        7520     7524       +4     
  Branches     2089     2092       +3     
==========================================
+ Hits         7231     7235       +4     
  Misses        287      287              
  Partials        2        2
Impacted Files Coverage Δ
components/tooltip/index.tsx 96.62% <100%> (+0.11%) ⬆️
components/checkbox/Checkbox.tsx 96.07% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91281e4...7ca85ad. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants