Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 carousel dotposition 问题 #20645

Merged
merged 1 commit into from Jan 3, 2020
Merged

fix: 修复 carousel dotposition 问题 #20645

merged 1 commit into from Jan 3, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jan 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20638

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the display error of carousel component with dotposition of left and righ
🇨🇳 Chinese 修复carousel 组件 dotposition 为 left 、right 的显示错误

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for ant-design ready!

Built with commit a717cd7

https://deploy-preview-20645--ant-design.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a717cd7:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #20645 into 4.0-prepare will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #20645      +/-   ##
===============================================
+ Coverage        97.56%   97.56%   +<.01%     
===============================================
  Files              295      295              
  Lines             6819     6820       +1     
  Branches          1890     1891       +1     
===============================================
+ Hits              6653     6654       +1     
  Misses             166      166
Impacted Files Coverage Δ
components/carousel/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493e987...a717cd7. Read the comment docs.

@afc163 afc163 merged commit a4ac7de into ant-design:4.0-prepare Jan 3, 2020
@xrkffgg xrkffgg deleted the fix-4.0 branch January 3, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants