Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add footer property to Drawer #20690

Merged
merged 1 commit into from Jan 6, 2020

Conversation

DeanVanNiekerk
Copy link
Contributor

@DeanVanNiekerk DeanVanNiekerk commented Jan 6, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update

馃敆 Related issue link

feature request - Drawer footer support

previous PR: #19779
close #15204

馃挕 Background and solution

I propose a solution to add a dedicated footer property on the Drawer component. This solution allows for a 'fixed' footer and title.

fixed

馃摑 Changelog

  • Add footer property to Drawer
Language Changelog
馃嚭馃嚫 English Add footer property to Drawer
馃嚚馃嚦 Chinese 灏嗛〉鑴氬睘鎬ф坊鍔犲埌鎶藉眽

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/drawer/demo/form-in-drawer.md
View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md


View rendered components/drawer/demo/form-in-drawer.md
View rendered components/drawer/demo/multi-level-drawer.md
View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

@netlify netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit eb94cf8

https://deploy-preview-20690--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb94cf8:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jan 6, 2020

Codecov Report

Merging #20690 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20690      +/-   ##
==========================================
+ Coverage   97.54%   97.57%   +0.03%     
==========================================
  Files         295      295              
  Lines        6836     6839       +3     
  Branches     1898     1854      -44     
==========================================
+ Hits         6668     6673       +5     
+ Misses        168      166       -2
Impacted Files Coverage 螖
components/drawer/index.tsx 98.78% <100%> (+0.09%) 猬嗭笍
components/progress/Steps.tsx 100% <0%> (+12.5%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update faa9692...eb94cf8. Read the comment docs.

@afc163 afc163 merged commit 019fdd5 into ant-design:master Jan 6, 2020
22 checks passed
@DeanVanNiekerk DeanVanNiekerk deleted the 4.0-prepare-drawer-footer branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants