Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table should not crash with empty column children #20703

Merged
merged 1 commit into from Jan 6, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 6, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

https://codesandbox.io/s/hopeful-volhard-gykps

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Table crash when columns with empty children.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot removed the PR: unreviewed label Jan 6, 2020
@netlify
Copy link

@netlify netlify bot commented Jan 6, 2020

Deploy preview for ant-design ready!

Built with commit e657dc8

https://deploy-preview-20703--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e657dc8:

Sandbox Source
antd reproduction template Configuration
sharp-field-qz87e PR

@chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Jan 6, 2020

鍠滃ぇ鏅

@codecov
Copy link

@codecov codecov bot commented Jan 6, 2020

Codecov Report

Merging #20703 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20703   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         295      295           
  Lines        6842     6842           
  Branches     1889     1856   -33     
=======================================
  Hits         6674     6674           
  Misses        168      168
Impacted Files Coverage 螖
components/table/hooks/useFilter/index.tsx 100% <100%> (酶) 猬嗭笍
components/table/hooks/useSorter.tsx 90.22% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 78f5607...e657dc8. Read the comment docs.

@zombieJ zombieJ merged commit 1c1a4a7 into master Jan 6, 2020
32 checks passed
@zombieJ zombieJ deleted the fix-table-crash branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants