Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 优化calendar若干样式 #20790

Merged
merged 3 commits into from Jan 9, 2020
Merged

style: 优化calendar若干样式 #20790

merged 3 commits into from Jan 9, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jan 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

https://next.ant.design/components/calendar-cn/

Before



💄 After


📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 1. 优化基本样式月份下拉框宽度;2. 优化通知事项的文字顺序;3. 优化卡片模式,选择框的尺寸

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

1. 基本样式月份下拉框宽度
2. 通知事项的文字反向
3. 卡片模式,选择框的尺寸
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 9, 2020

是不是固定调宽一丢丢就好了?仍然保持固定宽度如何?

@xrkffgg xrkffgg changed the title style:优化calendar若干样式 style: 优化calendar若干样式 Jan 9, 2020
@auto-add-label auto-add-label bot added the style label Jan 9, 2020
@netlify
Copy link

@netlify netlify bot commented Jan 9, 2020

Deploy preview for ant-design ready!

Built with commit c881f97

https://deploy-preview-20790--ant-design.netlify.com

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d030c9f:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c881f97:

Sandbox Source
antd reproduction template Configuration

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jan 9, 2020

@yoyo837 我看 3.26 是用的 min-width

@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #20790 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20790      +/-   ##
==========================================
- Coverage   97.47%   97.46%   -0.01%     
==========================================
  Files         296      296              
  Lines        6878     6877       -1     
  Branches     1865     1911      +46     
==========================================
- Hits         6704     6703       -1     
  Misses        174      174
Impacted Files Coverage Δ
components/calendar/Header.tsx 100% <ø> (ø) ⬆️
components/input/ClearableLabeledInput.tsx 100% <0%> (ø) ⬆️
components/input/Input.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17269e...c881f97. Read the comment docs.

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jan 9, 2020

width 好一些吗?

@afc163 afc163 removed the style label Jan 9, 2020
@zombieJ zombieJ requested review from AntDesigners and ycjcl868 Jan 9, 2020
zombieJ
zombieJ approved these changes Jan 9, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 9, 2020

width 好一些吗?

目前看没啥问题,有问题可以再改回来。

@zombieJ zombieJ merged commit 8a9e2c5 into ant-design:master Jan 9, 2020
21 checks passed
@xrkffgg xrkffgg deleted the k-calendar-css branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants