Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve #21120 update display names for layout components #21123

Merged

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented Jan 28, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #21120

馃挕 Background and solution

Add displayName property in GeneratorProps.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Use semantic display names instead of Adapter in Layout components.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 28, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 286e0e9:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #21123 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21123      +/-   ##
==========================================
+ Coverage   97.45%   97.45%   +<.01%     
==========================================
  Files         296      296              
  Lines        6911     6912       +1     
  Branches     1871     1918      +47     
==========================================
+ Hits         6735     6736       +1     
  Misses        176      176
Impacted Files Coverage 螖
components/layout/layout.tsx 92.3% <100%> (+0.2%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0f1629b...286e0e9. Read the comment docs.

@yoyo837 yoyo837 merged commit 8cf8c16 into ant-design:master Jan 28, 2020
@morenyang morenyang deleted the update-layout-components-display-name branch January 28, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Useless displaynames for base Layout components
3 participants