Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test case for ConfigProvider and Spin #21384

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 14, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69eb2fe:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a388148:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #21384 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21384      +/-   ##
==========================================
+ Coverage   97.77%   97.83%   +0.05%     
==========================================
  Files         300      300              
  Lines        7005     7005              
  Branches     1920     1931      +11     
==========================================
+ Hits         6849     6853       +4     
+ Misses        156      152       -4
Impacted Files Coverage Δ
components/config-provider/index.tsx 95.83% <0%> (+4.16%) ⬆️
components/spin/index.tsx 100% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc20e6e...a388148. Read the comment docs.

@afc163 afc163 merged commit 30a3ac6 into master Feb 14, 2020
@afc163 afc163 deleted the test-config-provider branch February 14, 2020 11:02
@pr-triage pr-triage bot added the PR: merged label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants