Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Declare TimePickerLocale typedef #22129

Merged
merged 1 commit into from Mar 11, 2020

Conversation

nossbigg
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Problem:

  • TimePicker doesn't have own Locale typedef

Solution:

  • Define TimePickerLocale typedef
  • Apply Locale types to locale files in components/time-picker/locale

📝 Changelog

Language Changelog
🇺🇸 English Define TimePickerLocale typedef
🇨🇳 Chinese Define TimePickerLocale typedef

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@nossbigg nossbigg changed the title feat: Declare TimePicker locale typedef feat: Declare TimePickerLocale typedef Mar 11, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 11, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 810965d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #22129 into feature will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22129   +/-   ##
========================================
  Coverage    97.98%   97.98%           
========================================
  Files          358      358           
  Lines         7142     7142           
  Branches      1958     1958           
========================================
  Hits          6998     6998           
  Misses         144      144           
Impacted Files Coverage Δ
components/time-picker/index.tsx 100.00% <ø> (ø)
components/time-picker/locale/ar_EG.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/az_AZ.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/bg_BG.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/ca_ES.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/cs_CZ.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/da_DK.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/de_DE.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/el_GR.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/en_GB.tsx 100.00% <100.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da215be...810965d. Read the comment docs.

@afc163 afc163 merged commit bf7f47a into ant-design:feature Mar 11, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants