Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: site support pwa #22412

Closed
wants to merge 1 commit into from
Closed

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Mar 19, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

To make the site support PWA and installed. Users can check site docs offline. Improve experience in terrible network.
image

📝 Changelog

Language Changelog
🇺🇸 English To make the site support PWA and installed.
🇨🇳 Chinese 网站支持 PWA 并且能够被安装。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@AshoneA
Copy link
Contributor Author

AshoneA commented Mar 19, 2020

第一次写 pwa 感觉缓存这部分还有点问题,先预览一下试试可不可行。想法来自于昨天你们的面试问题,用户打开网站感觉很慢怎么办...

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 19, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c8efaa:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #22412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22412   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         306      306           
  Lines        7046     7046           
  Branches     1928     1938   +10     
=======================================
  Hits         6911     6911           
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289d66a...1c8efaa. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Mar 19, 2020

pwa 之前上过,对于经常更新的网站有很多问题。不建议上。

@AshoneA
Copy link
Contributor Author

AshoneA commented Mar 19, 2020

pwa 之前上过,对于经常更新的网站有很多问题。不建议上。

是缓存这块经常会出问题吗?

@shaodahong
Copy link
Member

pwa 之前上过,对于经常更新的网站有很多问题。不建议上。

是缓存这块经常会出问题吗?

更新频繁,收益低,缓存命中率能够涵盖绝大部分,Antd 主站大部分静态资源都有 CDN 护体,用户本地文档出问题了排查困难(一旦出问题了就会觉得坑,弃用),而且 Antd 服务器在国外,你用神秘力量试试完全是两个体验

@afc163
Copy link
Member

afc163 commented Mar 20, 2020

PWA 的缓存会导致更新不及时和部分路径变化(新增路径/修改路径)后的 404。

@AshoneA
Copy link
Contributor Author

AshoneA commented Mar 20, 2020

@afc163 @shaodahong 看来大家都是踩过坑的人... 那我周末再看下,感觉不行的话我自己关了。

@AshoneA AshoneA closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants