Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test: 馃殌 New Image Snapshots #22459

Closed
wants to merge 17 commits into from
Closed

[WIP] test: 馃殌 New Image Snapshots #22459

wants to merge 17 commits into from

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 21, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Maybe resolve #20866 ?

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 21, 2020

@shaodahong
Copy link
Member Author

shaodahong commented Mar 21, 2020

Steps:

  1. Run local server, like http://127.0.0.1:5000, responce a empty html with antd.css
  2. Use puppeteer launch and use renderToStaticMarkup parse JSX to html
  3. Append html and screenshot
  4. Expect screenshot image to match

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf6b819:

Sandbox Source
antd reproduction template Configuration

@shaodahong
Copy link
Member Author

Output fail base64 Ref: americanexpress/jest-image-snapshot#183 (comment)

@@ -213,6 +218,7 @@
"preact-compat": "^3.18.5",
"prettier": "^2.0.1",
"pretty-quick": "^2.0.0",
"puppeteer": "^2.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about puppeteer-core, or it would download the whole Chromium every install?

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #22459 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22459   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7270     7270           
  Branches     1976     1976           
=======================================
  Hits         7181     7181           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 612bcdf...cf6b819. Read the comment docs.

@shaodahong
Copy link
Member Author

Need work in the main git repository.

@shaodahong shaodahong closed this May 9, 2020
@shaodahong shaodahong mentioned this pull request May 9, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer for UI testing ci build
3 participants