-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] test: 馃殌 New Image Snapshots #22459
Conversation
Steps:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf6b819:
|
Output fail base64 Ref: americanexpress/jest-image-snapshot#183 (comment) |
@@ -213,6 +218,7 @@ | |||
"preact-compat": "^3.18.5", | |||
"prettier": "^2.0.1", | |||
"pretty-quick": "^2.0.0", | |||
"puppeteer": "^2.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about puppeteer-core
, or it would download the whole Chromium every install?
Codecov Report
@@ Coverage Diff @@
## master #22459 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 364 364
Lines 7270 7270
Branches 1976 1976
=======================================
Hits 7181 7181
Misses 89 89 Continue to review full report at Codecov.
|
Need work in the main git repository. |
馃 This is a ...
馃敆 Related issue link
Maybe resolve #20866 ?
馃挕 Background and solution
馃摑 Changelog
鈽戯笍 Self Check before Merge