New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): fix sorter and filter table compact mode style #22838
Conversation
40f2b0b
to
9e88532
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40f2b0b348ba122923afe1c50e1febe73928c771:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ca766c:
|
Codecov Report
@@ Coverage Diff @@
## master #22838 +/- ##
==========================================
- Coverage 98.31% 98.28% -0.04%
==========================================
Files 363 361 -2
Lines 7244 7211 -33
Branches 1988 1933 -55
==========================================
- Hits 7122 7087 -35
- Misses 122 124 +2
Continue to review full report at Codecov.
|
Note: this causes a styling bug where small and middle-size tables incorrectly render with a large header row. An open PR is set to correct this: ant-design/ant-design#22838
conflicted |
9e88532
to
7ca766c
Compare
@@ -28,9 +20,3 @@ | |||
// = Small = | |||
// ================================================================ | |||
.table-size(~'small', @table-padding-vertical-sm, @table-padding-horizontal-sm); | |||
|
|||
.@{table-prefix-cls}.@{table-prefix-cls}-small { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afc163 这边小号 background 好像特意设置其他颜色的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是 bug,4.x 之后应该一直是灰色。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌,ref: #22872
fix #22777
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
之前用的 margin 负值来定位感觉有点奇怪,可能是有什么情况需要这样做吗? @zombieJ 帮忙 review 一下会不会出现 break change。
📝 Changelog
☑️ Self Check before Merge
View rendered components/table/demo/size.md