Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor the button test to use typescript #22953

Merged
merged 4 commits into from
Apr 13, 2020

Conversation

fa93hws
Copy link
Contributor

@fa93hws fa93hws commented Apr 6, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

Most of the tests are still in javascript...

Pending on ant-design/antd-tools#137

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@fa93hws fa93hws changed the title Refactor the button test to use typescript chore: Refactor the button test to use typescript Apr 6, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a82db0f:

Sandbox Source
antd reproduction template Configuration

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 6, 2020

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #22953 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22953   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         365      365           
  Lines        7285     7285           
  Branches     1998     1998           
=======================================
  Hits         7165     7165           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 653724b...a82db0f. Read the comment docs.

@afc163 afc163 merged commit 7bc3d4f into ant-design:master Apr 13, 2020
xrkffgg pushed a commit that referenced this pull request Apr 13, 2020
* Refactor the button test to use typescript

* update tsconfig.json

* Change file name as a workaround

* update antd-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants