Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix console warning typo (validate -> a valid) #23240

Merged
merged 1 commit into from Apr 14, 2020

Conversation

evancharlton
Copy link
Contributor

@evancharlton evancharlton commented Apr 14, 2020

Clean up the typos in the helpful console warning messages which get
emitted if the incorrect prop is passed to certain components.

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

No related issue; I just noticed this while doing some development.

馃挕 Background and solution

Problem: bad grammar is used in the console warning.
Solution: correct the emitted log message text

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Clean up the typos in the helpful console warning messages which get
emitted if the incorrect prop is passed to certain components.
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@evancharlton
Copy link
Contributor Author

@evancharlton evancharlton commented Apr 14, 2020

Could you please add tests to make sure this change works as expected?

Tests were updated and the relevant tests are passing locally.

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 14, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f97cea:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 14, 2020

Codecov Report

Merging #23240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23240   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         365      365           
  Lines        7284     7284           
  Branches     1999     1999           
=======================================
  Hits         7164     7164           
  Misses        120      120           
Impacted Files Coverage 螖
components/checkbox/Checkbox.tsx 100.00% <酶> (酶)
components/switch/index.tsx 100.00% <酶> (酶)
components/upload/Upload.tsx 99.18% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8c11676...2f97cea. Read the comment docs.

@yoyo837 yoyo837 changed the title chore: Fix console warning typo (validate -> valid) chore: Fix console warning typo (validate -> a valid) Apr 14, 2020
@afc163 afc163 merged commit 58c6900 into ant-design:master Apr 14, 2020
21 checks passed
xrkffgg pushed a commit that referenced this issue Apr 16, 2020
Clean up the typos in the helpful console warning messages which get
emitted if the incorrect prop is passed to certain components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants