-
-
Notifications
You must be signed in to change notification settings - Fork 51.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix console warning typo (validate -> a valid) #23240
Conversation
Clean up the typos in the helpful console warning messages which get emitted if the incorrect prop is passed to certain components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Tests were updated and the relevant tests are passing locally. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f97cea:
|
Codecov Report
@@ Coverage Diff @@
## master #23240 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 365 365
Lines 7284 7284
Branches 1999 1999
=======================================
Hits 7164 7164
Misses 120 120
Continue to review full report at Codecov.
|
Clean up the typos in the helpful console warning messages which get emitted if the incorrect prop is passed to certain components.
Clean up the typos in the helpful console warning messages which get
emitted if the incorrect prop is passed to certain components.
🤔 This is a ...
🔗 Related issue link
No related issue; I just noticed this while doing some development.
💡 Background and solution
Problem: bad grammar is used in the console warning.
Solution: correct the emitted log message text
📝 Changelog
☑️ Self Check before Merge