Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix button loading rtl #23399

Merged
merged 1 commit into from Apr 20, 2020
Merged

style: fix button loading rtl #23399

merged 1 commit into from Apr 20, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 20, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #23395

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Button RTL loading icon
馃嚚馃嚦 Chinese 淇 Button RTL loading 鎸夐挳

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg requested review from afc163 and zombieJ Apr 20, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 20, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit caf49ad:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #23395

@afc163
Copy link
Member

@afc163 afc163 commented Apr 20, 2020

/rebase

@codecov
Copy link

@codecov codecov bot commented Apr 20, 2020

Codecov Report

Merging #23399 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23399   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         364      364           
  Lines        7320     7320           
  Branches     2004     2004           
=======================================
  Hits         7202     7202           
  Misses        118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e797d44...caf49ad. Read the comment docs.

@afc163 afc163 merged commit e2dacde into master Apr 20, 2020
31 checks passed
@afc163 afc163 deleted the fix-button-rtl branch Apr 20, 2020
webberwang pushed a commit to webberwang/ant-design that referenced this issue Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants