Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tree): rewrite with hook #23550

Merged
merged 9 commits into from
Apr 25, 2020
Merged

refactor(tree): rewrite with hook #23550

merged 9 commits into from
Apr 25, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 24, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor with hook
🇨🇳 Chinese 用 react hook 重构

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 24, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21567dd:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #23550 into master will increase coverage by 0.01%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23550      +/-   ##
==========================================
+ Coverage   98.50%   98.51%   +0.01%     
==========================================
  Files         363      363              
  Lines        7267     7254      -13     
  Branches     2001     2001              
==========================================
- Hits         7158     7146      -12     
+ Misses        109      108       -1     
Impacted Files Coverage Δ
components/tree/DirectoryTree.tsx 98.85% <98.30%> (+0.95%) ⬆️
components/tree/Tree.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c56b6...21567dd. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Apr 24, 2020

https://github.com/ant-design/ant-design/projects/6

把 todo 的卡片也建起来。

@hengkx
Copy link
Member Author

hengkx commented Apr 24, 2020

奇怪文件行数减少了,单元测试没变,覆盖率还变少了:sob:

@afc163
Copy link
Member

afc163 commented Apr 24, 2020

@hengkx hengkx requested a review from afc163 April 24, 2020 04:22
@hengkx
Copy link
Member Author

hengkx commented Apr 24, 2020

image
部署出错,一个包刚更新还找不到,这个要怎么解决
@afc163

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 24, 2020

用的cnpm的话 网页请求一下同步

@hengkx
Copy link
Member Author

hengkx commented Apr 24, 2020

用的cnpm的话 网页请求一下同步

这是
image

@afc163
Copy link
Member

afc163 commented Apr 24, 2020

有个外部依赖包出问题了,我试试重新部署。

@afc163
Copy link
Member

afc163 commented Apr 24, 2020

/rebase

@zombieJ
Copy link
Member

zombieJ commented Apr 24, 2020

看一下 findByDOMNode 会不会挂,其他没啥问题。

@hengkx
Copy link
Member Author

hengkx commented Apr 24, 2020

看一下 findByDOMNode 会不会挂,其他没啥问题。

什么地方 有用到?或者是怎么看 不太明白

@zombieJ
Copy link
Member

zombieJ commented Apr 25, 2020

什么地方 有用到?或者是怎么看 不太明白

开发者可能会通过 findDOMNode 来获取 Tree 的 DOM 节点。antd 本身不会用到。

@hengkx
Copy link
Member Author

hengkx commented Apr 25, 2020

看了一下代码 这个应该没有影响的

@zombieJ zombieJ merged commit 54f2abf into master Apr 25, 2020
@zombieJ zombieJ deleted the refactor/tree branch April 25, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants