Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert base rtl style #23714

Merged
merged 1 commit into from Apr 28, 2020
Merged

fix: alert base rtl style #23714

merged 1 commit into from Apr 28, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 这个 PR 修复了 一个问题,#23526
    但未修改测试完整,引起了另一个问题,no-icon 的情况下 多了间隔,这个 PR 补充一下

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Alert style in RTL when no-icon
🇨🇳 Chinese 修复 Alert 在 RTL 下无 icon 的 间隔问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 28, 2020

@@ -9,6 +9,12 @@
direction: rtl;
}

&&-no-icon {
.@{alert-prefix-cls}-rtl& {
padding: @alert-no-icon-padding-vertical 15px;
Copy link
Member

@afc163 afc163 Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15px 是不是也应该用变量。

Copy link
Member Author

@xrkffgg xrkffgg Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, 我加一个变量

Copy link
Member

@afc163 afc163 Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是加,是不是应该用已有变量。

Copy link
Member Author

@xrkffgg xrkffgg Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了一下,index.less 中 好几个都直接 使用了固定的 px 。我觉得 这个值 还是暂时不提前到变量了

Copy link
Member Author

@xrkffgg xrkffgg Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 先不改这个了,不过里面的 37px, 我都不知道 以前 是怎么 给出的 😂😂

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e326819:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

@afc163 afc163 commented Apr 28, 2020

/rebase

@afc163 afc163 merged commit 16a1feb into master Apr 28, 2020
18 of 21 checks passed
@afc163 afc163 deleted the opt-alert-rtl branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants