fix: alert base rtl style #23714
Merged
fix: alert base rtl style #23714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afc163
reviewed
Apr 28, 2020
| @@ -9,6 +9,12 @@ | |||
| direction: rtl; | |||
| } | |||
|
|
|||
| &&-no-icon { | |||
| .@{alert-prefix-cls}-rtl& { | |||
| padding: @alert-no-icon-padding-vertical 15px; | |||
There was a problem hiding this comment.
看了一下，index.less 中 好几个都直接 使用了固定的 px 。我觉得 这个值 还是暂时不提前到变量了
There was a problem hiding this comment.
这个 PR 先不改这个了，不过里面的 37px， 我都不知道 以前 是怎么 给出的 😂😂
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e326819:
|
|
/rebase |
github-actions
bot
force-pushed
the
opt-alert-rtl
branch
from
cb3ff1f
to
ec1a17f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
但未修改测试完整，引起了另一个问题，no-icon 的情况下 多了间隔，这个 PR 补充一下
📝 Changelog
☑️ Self Check before Merge