Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix crash when mismatch placement #23756

Merged
merged 2 commits into from Apr 29, 2020
Merged

fix: Fix crash when mismatch placement #23756

merged 2 commits into from Apr 29, 2020

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 29, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #23541

📝 Changelog

Language Changelog
🇺🇸 English Fix crash when mismatch placement
🇨🇳 Chinese 修复 Tooltipalign 未匹配到支持的 placement 时异常的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 29, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc00d40:

Sandbox Source
antd reproduction template Configuration
Basic - Ant Design Demo Issue #23541

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #23756 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23756      +/-   ##
==========================================
- Coverage   98.53%   98.51%   -0.02%     
==========================================
  Files         363      363              
  Lines        7212     7214       +2     
  Branches     1956     2004      +48     
==========================================
+ Hits         7106     7107       +1     
- Misses        106      107       +1     
Impacted Files Coverage Δ
components/tooltip/index.tsx 98.92% <50.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1299bf...cc00d40. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Apr 29, 2020

加个 测试用例,今天准备发 minor,争取这次就合进来。

@yoyo837
Copy link
Contributor Author

yoyo837 commented Apr 29, 2020

npm cnpm 都不行,跑不过。

@yoyo837
Copy link
Contributor Author

yoyo837 commented Apr 29, 2020

应该是切换分支3.x-stable编译的jsx干扰了。

@zombieJ
Copy link
Member

zombieJ commented Apr 29, 2020

git clean -fdx 后,npm install 应该就好了。

@zombieJ zombieJ merged commit 935b0e5 into master Apr 29, 2020
@zombieJ zombieJ deleted the fix-tooltip-crash branch April 29, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal exception thrown when tooltip is shown after upgrading to antd 4.1.4
3 participants