Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ConfigProvider support virtual and dropdownMatchSelectWidth #23841

Merged
merged 5 commits into from May 5, 2020
Merged

feat: ConfigProvider support virtual and dropdownMatchSelectWidth #23841

merged 5 commits into from May 5, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented May 4, 2020 •
edited

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

close #22456

πŸ’‘ Background and solution

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English ConfigProvider support virtual and dropdownMatchSelectWidth
πŸ‡¨πŸ‡³ Chinese ConfigProvider ζ”―ζŒ virtual ε’Œ dropdownMatchSelectWidth

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/config-provider/index.en-US.md
View rendered components/config-provider/index.zh-CN.md

@hengkx hengkx requested a review from zombieJ as a code owner May 4, 2020 00:48
tests-checker[bot]
tests-checker bot suggested changes May 4, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@hengkx hengkx removed their assignment May 4, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 4, 2020 •
edited

@hengkx
Copy link
Member Author

hengkx commented May 4, 2020

/rebase

@zombieJ zombieJ merged commit 747691f into feature May 5, 2020
@zombieJ zombieJ deleted the feat-config branch May 5, 2020 07:00
@zombieJ zombieJ mentioned this pull request May 31, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hengkx @ant-design-bot @zombieJ