Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: paramter type error #23947

Closed
wants to merge 1 commit into from
Closed

fix: paramter type error #23947

wants to merge 1 commit into from

Conversation

fireairforce
Copy link
Member

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#22040

馃挕 Background and solution

@fireairforce fireairforce requested a review from zombieJ as a code owner May 7, 2020 16:03
@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 7, 2020 •
edited

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9665884:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 549f6528b795a436666dbf23ddc906092c74ef29:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dd520c2123a6e3c366eb952e6ec6b08bb439ce1:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented May 7, 2020 •
edited

Codecov Report

Merging #23947 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23947   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7270     7270           
  Branches     2014     2024   +10     
=======================================
  Hits         7181     7181           
  Misses         89       89
Impacted Files Coverage 螖
components/tree/Tree.tsx 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c4b602e...9665884. Read the comment docs.

@fireairforce fireairforce force-pushed the master branch 2 times, most recently from 0dd520c to 9665884 Compare May 8, 2020 02:25
zombieJ
zombieJ reviewed May 8, 2020
View reviewed changes
components/tree/Tree.tsx
@@ -43,7 +43,7 @@ export interface AntTreeNodeProps {
selected?: boolean;
selectable?: boolean;
icon?: ((treeNode: AntdTreeNodeAttribute) => React.ReactNode) | React.ReactNode;
children?: React.ReactNode;
children?: React.ReactNode[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鎴睆2020-05-08 涓婂崍11 05 50

ReactNode already contains ReactNode[]. No need to modify this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, here is a Object Type?

@zombieJ
Copy link
Member

zombieJ commented May 8, 2020

Seem your patch v4 branch to fix v3 issue. Please double confirm.

@fireairforce
Copy link
Member Author

ok. i will close this~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fireairforce @ant-design-bot @zombieJ