fix: Add closeIcon for Tabs.Tabpane #23992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5cc29d2:
|
afc163
reviewed
May 9, 2020
components/tabs/index.zh-CN.md
Outdated
| @@ -49,3 +49,4 @@ Ant Design 依次提供了三级选项卡，分别用于不同的场景。 | |||
| | forceRender | 被隐藏时是否渲染 DOM 结构 | boolean | false | | |||
| | key | 对应 activeKey | string | 无 | | |||
| | tab | 选项卡头显示文字 | string\|ReactNode | 无 | | |||
| | closeIcon | 自定义关闭图标 | ReactNode | 无 | | |||
afc163
reviewed
May 9, 2020
components/tabs/index.zh-CN.md
Outdated
| | forceRender | 被隐藏时是否渲染 DOM 结构 | boolean | false | | ||
| | key | 对应 activeKey | string | 无 | | ||
| | tab | 选项卡头显示文字 | string\|ReactNode | 无 | | ||
| | closeIcon | 自定义关闭图标，在 type="editable-card" 时有效 | ReactNode | 无 | |
There was a problem hiding this comment.
Suggested change
| | closeIcon | 自定义关闭图标，在 type="editable-card" 时有效 | ReactNode | 无 | | |
| | closeIcon | 自定义关闭图标，在 `type="editable-card"` 时有效 | ReactNode | 无 | |
There was a problem hiding this comment.
如果在一个Tabs里面的多个TabPane，需要固定几个TabPane不允许被关闭，其他都是可以关闭的，即：Tabs->type="editable-card"，但是这样 所有的TabPane都可以出现关闭图标，可否在每个TabPane中设置不现实关闭图标，类似closeIcon={null}这样
There was a problem hiding this comment.
sorry，刚看到应该在新版本中支持了，<TabPane tab={pane.title} key={pane.key} closable={pane.closable}>
|
rebase master |
|
补充一下信息。 |
|
feature branch |
njmqd
force-pushed
the
feature-tabs-custom-closeIcon
branch
from
4c7f57d
to
4cb70b6
Compare
|
Commits should be clean. |
added 2 commits
May 11, 2020 10:50
afc163
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
close #23958
💡 Background and solution
📝 Changelog
closeIconof TabpanecloseIcon属性支持自定义关闭图标。☑️ Self Check before Merge
View rendered components/tabs/demo/editable-card.md
View rendered components/tabs/index.en-US.md
View rendered components/tabs/index.zh-CN.md