New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(modal): rewrite with hook and support strict mode #24238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Codecov Report
@@ Coverage Diff @@
## master #24238 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 363 363
Lines 7280 7280
Branches 2015 2017 +2
=======================================
Hits 7194 7194
Misses 86 86
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
- Fix Modal
confirmLoading
button not reset.- 修复 Modal 关闭后
confirmLoading
按钮没有复位的问题。☑️ Self Check before Merge