Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(modal): rewrite with hook and support strict mode #24238

Merged
merged 3 commits into from May 19, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented May 18, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English - Refactor Modal with hooks and support strict mode.
- Fix Modal confirmLoading button not reset.
🇨🇳 Chinese - 使用 Hooks 重构 Modal,使其兼容于严格模式。
- 修复 Modal 关闭后 confirmLoading 按钮没有复位的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 18, 2020

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #24238 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24238   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         363      363           
  Lines        7280     7280           
  Branches     2015     2017    +2     
=======================================
  Hits         7194     7194           
  Misses         86       86           
Impacted Files Coverage Δ
components/modal/index.tsx 100.00% <ø> (ø)
components/modal/ActionButton.tsx 100.00% <100.00%> (ø)
components/modal/Modal.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a52cf0...24aeb3e. Read the comment docs.

components/modal/Modal.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants